2023-08-04 18:40:13

by Frank Li

[permalink] [raw]
Subject: [PATCH v9 1/3] PCI: Add macro PCIE_PME_TO_L2_TIMEOUT_US

Introduces the PCIE_PME_TO_L2_TIMEOUT_US macro to facilitate checking the
PME (Power Management Event) timeout in the PCI subsystem.

Signed-off-by: Frank Li <[email protected]>
---
drivers/pci/pci.h | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index a4c3974340576..da8156663c825 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -13,6 +13,12 @@

#define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000

+/*
+ * PCIe r6.0, sec 5.3.3.2.1 <PME Synchronization>
+ * Recommends 1ms to 10ms timeout to check L2 ready.
+ */
+#define PCIE_PME_TO_L2_TIMEOUT_US 10000
+
extern const unsigned char pcie_link_speed[];
extern bool pci_early_dump;

--
2.34.1



2023-08-07 14:25:47

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH v9 1/3] PCI: Add macro PCIE_PME_TO_L2_TIMEOUT_US

On Fri, Aug 04, 2023 at 02:06:35PM -0400, Frank Li wrote:
> Introduces the PCIE_PME_TO_L2_TIMEOUT_US macro to facilitate checking the

s/Introduces/Introduce

> PME (Power Management Event) timeout in the PCI subsystem.
>

L2 ready timeout

> Signed-off-by: Frank Li <[email protected]>

With above changes,

Acked-by: Manivannan Sadhasivam <[email protected]>

- Mani

> ---
> drivers/pci/pci.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index a4c3974340576..da8156663c825 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -13,6 +13,12 @@
>
> #define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000
>
> +/*
> + * PCIe r6.0, sec 5.3.3.2.1 <PME Synchronization>
> + * Recommends 1ms to 10ms timeout to check L2 ready.
> + */
> +#define PCIE_PME_TO_L2_TIMEOUT_US 10000
> +
> extern const unsigned char pcie_link_speed[];
> extern bool pci_early_dump;
>
> --
> 2.34.1
>

--
மணிவண்ணன் சதாசிவம்