2023-08-02 13:25:58

by Alexandru Ardelean

Subject: Re: [PATCH] iio: trigger: stm32-lptimer-trigger: remove unneeded platform_set_drvdata()

On Wed, Aug 2, 2023 at 3:09 PM Andrei Coardos <[email protected]> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <[email protected]>
> Signed-off-by: Andrei Coardos <[email protected]>
> ---
> drivers/iio/trigger/stm32-lptimer-trigger.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/trigger/stm32-lptimer-trigger.c b/drivers/iio/trigger/stm32-lptimer-trigger.c
> index 2e447a3f047d..df2416e33375 100644
> --- a/drivers/iio/trigger/stm32-lptimer-trigger.c
> +++ b/drivers/iio/trigger/stm32-lptimer-trigger.c
> @@ -92,8 +92,6 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev)
> if (ret)
> return ret;

this can become now:

return stm32_lptim_setup_trig(priv);


>
> - platform_set_drvdata(pdev, priv);
> -
> return 0;
> }
>
> --
> 2.34.1
>

2023-08-05 19:18:24

by Jonathan Cameron

Subject: Re: [PATCH] iio: trigger: stm32-lptimer-trigger: remove unneeded platform_set_drvdata()

On Wed, 2 Aug 2023 15:37:02 +0300
Alexandru Ardelean <[email protected]> wrote:

> On Wed, Aug 2, 2023 at 3:09 PM Andrei Coardos <[email protected]> wrote:
> >
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
> >
> > Reviewed-by: Alexandru Ardelean <[email protected]>
> > Signed-off-by: Andrei Coardos <[email protected]>
> > ---
> > drivers/iio/trigger/stm32-lptimer-trigger.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/iio/trigger/stm32-lptimer-trigger.c b/drivers/iio/trigger/stm32-lptimer-trigger.c
> > index 2e447a3f047d..df2416e33375 100644
> > --- a/drivers/iio/trigger/stm32-lptimer-trigger.c
> > +++ b/drivers/iio/trigger/stm32-lptimer-trigger.c
> > @@ -92,8 +92,6 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev)
> > if (ret)
> > return ret;
>
> this can become now:
>
> return stm32_lptim_setup_trig(priv);
I made that change whilst applying.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to take a look at it and see if they can find anything
we missed.

Thanks,

Jonathan

>
>
> >
> > - platform_set_drvdata(pdev, priv);
> > -
> > return 0;
> > }
> >
> > --
> > 2.34.1
> >