2023-08-07 19:45:30

by Jeff Layton

Subject: [PATCH v7 01/13] fs: remove silly warning from current_time

An inode with no superblock? Unpossible!

Signed-off-by: Jeff Layton <[email protected]>
---
fs/inode.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c
index d4ab92233062..3fc251bfaf73 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2495,12 +2495,6 @@ struct timespec64 current_time(struct inode *inode)
struct timespec64 now;

ktime_get_coarse_real_ts64(&now);
-
- if (unlikely(!inode->i_sb)) {
- WARN(1, "current_time() called with uninitialized super_block in the inode");
- return now;
- }
-
return timestamp_truncate(now, inode);
}
EXPORT_SYMBOL(current_time);

--
2.41.0

2023-08-08 18:50:06

by Jan Kara

Subject: Re: [PATCH v7 01/13] fs: remove silly warning from current_time

On Mon 07-08-23 15:38:32, Jeff Layton wrote:
> An inode with no superblock? Unpossible!
>
> Signed-off-by: Jeff Layton <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/inode.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index d4ab92233062..3fc251bfaf73 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -2495,12 +2495,6 @@ struct timespec64 current_time(struct inode *inode)
> struct timespec64 now;
>
> ktime_get_coarse_real_ts64(&now);
> -
> - if (unlikely(!inode->i_sb)) {
> - WARN(1, "current_time() called with uninitialized super_block in the inode");
> - return now;
> - }
> -
> return timestamp_truncate(now, inode);
> }
> EXPORT_SYMBOL(current_time);
>
> --
> 2.41.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR