2023-08-08 18:43:22

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example

Bindings require vdd-supply but the example DTS was missing one. This
fixes dt_binding_check error:

Documentation/devicetree/bindings/iio/light/rohm,bu27010.example.dtb: light-sensor@38: 'vdd-supply' is a required property

Fixes: ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml b/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
index 8376d64a641a..bed42d5d0d94 100644
--- a/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
+++ b/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
@@ -45,5 +45,6 @@ examples:
light-sensor@38 {
compatible = "rohm,bu27010";
reg = <0x38>;
+ vdd-supply = <&vdd>;
};
};
--
2.34.1



2023-08-08 20:36:24

by Matti Vaittinen

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example

On 8/8/23 09:32, Krzysztof Kozlowski wrote:
> Bindings require vdd-supply but the example DTS was missing one. This
> fixes dt_binding_check error:
>
> Documentation/devicetree/bindings/iio/light/rohm,bu27010.example.dtb: light-sensor@38: 'vdd-supply' is a required property
>
> Fixes: ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Ah. Added supply to required ones when you pointed out it should be -
and obviously didn't fix the example :/

Thanks a lot for fixing it!

Reviewed-by: Matti Vaittinen <[email protected]>

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~


2023-08-11 15:20:08

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example

On Tue, Aug 08, 2023 at 08:32:23AM +0200, Krzysztof Kozlowski wrote:
> Bindings require vdd-supply but the example DTS was missing one. This
> fixes dt_binding_check error:
>
> Documentation/devicetree/bindings/iio/light/rohm,bu27010.example.dtb: light-sensor@38: 'vdd-supply' is a required property
>
> Fixes: ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Rob Herring <[email protected]>

2023-09-04 06:37:38

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example

On Fri, 11 Aug 2023 09:17:55 -0600
Rob Herring <[email protected]> wrote:

> On Tue, Aug 08, 2023 at 08:32:23AM +0200, Krzysztof Kozlowski wrote:
> > Bindings require vdd-supply but the example DTS was missing one. This
> > fixes dt_binding_check error:
> >
> > Documentation/devicetree/bindings/iio/light/rohm,bu27010.example.dtb: light-sensor@38: 'vdd-supply' is a required property
> >
> > Fixes: ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
> Acked-by: Rob Herring <[email protected]>
Applied to the fixes-togreg branch of iio.git.
Note I want to rebase that on rc1 before sending next pull request so it will be a week or two.

Thanks,

Jonathan