2023-08-08 18:44:53

by Xi Ruoyao

[permalink] [raw]
Subject: [PATCH v2] LoongArch: Remove redundant "source drivers/firmware/Kconfig"

In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so
there is no need to source it in the port-specific Kconfig file. And
sourcing it here also caused the "Firmware Drivers" menu appeared two
times: once in the "Device Drivers" menu, another time in the toplevel
menu. This was really puzzling.

Signed-off-by: Xi Ruoyao <[email protected]>
---
arch/loongarch/Kconfig | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
index e71d5bf2cee0..465759f6b0ed 100644
--- a/arch/loongarch/Kconfig
+++ b/arch/loongarch/Kconfig
@@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
source "drivers/acpi/Kconfig"

endmenu
-
-source "drivers/firmware/Kconfig"
--
2.41.0



2023-08-08 23:41:14

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH v2] LoongArch: Remove redundant "source drivers/firmware/Kconfig"



On 8/8/23 00:55, Xi Ruoyao wrote:
> In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so
> there is no need to source it in the port-specific Kconfig file. And
> sourcing it here also caused the "Firmware Drivers" menu appeared two
> times: once in the "Device Drivers" menu, another time in the toplevel
> menu. This was really puzzling.
>
> Signed-off-by: Xi Ruoyao <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> arch/loongarch/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index e71d5bf2cee0..465759f6b0ed 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
> source "drivers/acpi/Kconfig"
>
> endmenu
> -
> -source "drivers/firmware/Kconfig"

--
~Randy