2023-08-08 18:13:20

by Jerome Brunet

[permalink] [raw]
Subject: [PATCH 0/2] usb: misc: onboard_usb_hub: add gl3510 support

This patchset adds the bindings and driver support to trigger the reset
pin of the Genesys Logic gl3510 usb hub.

Jerome Brunet (2):
dt-bindings: usb: add device for Genesys Logic hub gl3510
usb: misc: onboard_usb_hub: add Genesys Logic gl3510 hub support

Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 3 ++-
drivers/usb/misc/onboard_usb_hub.h | 5 +++++
2 files changed, 7 insertions(+), 1 deletion(-)

--
2.40.1



2023-08-08 20:01:31

by Jerome Brunet

[permalink] [raw]
Subject: [PATCH 2/2] usb: misc: onboard_usb_hub: add Genesys Logic gl3510 hub support

Add support for the gl3510 4 ports USB3.1 hub. This allows to control its
reset pins with a gpio.

No public documentation is available for this hub. Using the same reset
duration as the gl852g which seems OK.

Signed-off-by: Jerome Brunet <[email protected]>
---
drivers/usb/misc/onboard_usb_hub.h | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h
index aca5f50eb0da..4b94ea375d45 100644
--- a/drivers/usb/misc/onboard_usb_hub.h
+++ b/drivers/usb/misc/onboard_usb_hub.h
@@ -22,6 +22,10 @@ static const struct onboard_hub_pdata ti_tusb8041_data = {
.reset_us = 3000,
};

+static const struct onboard_hub_pdata genesys_gl3510_data = {
+ .reset_us = 50,
+};
+
static const struct onboard_hub_pdata genesys_gl850g_data = {
.reset_us = 3,
};
@@ -41,6 +45,7 @@ static const struct of_device_id onboard_hub_match[] = {
{ .compatible = "usb451,8142", .data = &ti_tusb8041_data, },
{ .compatible = "usb5e3,608", .data = &genesys_gl850g_data, },
{ .compatible = "usb5e3,610", .data = &genesys_gl852g_data, },
+ { .compatible = "usb5e3,626", .data = &genesys_gl3510_data, },
{ .compatible = "usbbda,411", .data = &realtek_rts5411_data, },
{ .compatible = "usbbda,5411", .data = &realtek_rts5411_data, },
{ .compatible = "usbbda,414", .data = &realtek_rts5411_data, },
--
2.40.1


2023-08-08 21:55:56

by Jerome Brunet

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: usb: add device for Genesys Logic hub gl3510

Add gl3510 USB 3 root hub device id

Signed-off-by: Jerome Brunet <[email protected]>
---
Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
index cc4cf92b70d1..a7e7142651f8 100644
--- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
+++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

-title: Genesys Logic GL850G USB 2.0 hub controller
+title: Genesys Logic USB hub controller

maintainers:
- Icenowy Zheng <[email protected]>
@@ -17,6 +17,7 @@ properties:
enum:
- usb5e3,608
- usb5e3,610
+ - usb5e3.626

reg: true

--
2.40.1


2023-08-08 21:57:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: usb: add device for Genesys Logic hub gl3510

On 08/08/2023 12:07, Jerome Brunet wrote:
> Add gl3510 USB 3 root hub device id
>
> Signed-off-by: Jerome Brunet <[email protected]>
> ---


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2023-08-11 00:03:43

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: usb: add device for Genesys Logic hub gl3510

On Tue, Aug 08, 2023 at 12:07:45PM +0200, Jerome Brunet wrote:
> Add gl3510 USB 3 root hub device id
>
> Signed-off-by: Jerome Brunet <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> index cc4cf92b70d1..a7e7142651f8 100644
> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Genesys Logic GL850G USB 2.0 hub controller
> +title: Genesys Logic USB hub controller
>
> maintainers:
> - Icenowy Zheng <[email protected]>
> @@ -17,6 +17,7 @@ properties:
> enum:
> - usb5e3,608
> - usb5e3,610
> + - usb5e3.626

Should be a comma, not a period.

>
> reg: true
>
> --
> 2.40.1
>