2023-08-08 16:35:11

by Yue Haibing

Subject: [PATCH -next] dmaengine: Remove unused declaration dma_chan_cleanup()

Commit f27c580c3628 ("dmaengine: remove 'bigref' infrastructure")
removed the implementation but leave declaration.

Signed-off-by: Yue Haibing <[email protected]>
---
include/linux/dmaengine.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index c3656e590213..3df70d6131c8 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -517,8 +517,6 @@ static inline const char *dma_chan_name(struct dma_chan *chan)
return dev_name(&chan->dev->device);
}

-void dma_chan_cleanup(struct kref *kref);
-
/**
* typedef dma_filter_fn - callback filter for dma_request_channel
* @chan: channel to be reviewed
--
2.34.1

2023-08-08 22:26:00

by Andy Shevchenko

Subject: Re: [PATCH -next] dmaengine: Remove unused declaration dma_chan_cleanup()

On Tue, Aug 08, 2023 at 11:05:17PM +0800, Yue Haibing wrote:
> Commit f27c580c3628 ("dmaengine: remove 'bigref' infrastructure")
> removed the implementation but leave declaration.

"...left declaration in place. Remove it."

Reviewed-by: Andy Shevchenko <[email protected]>

--
With Best Regards,
Andy Shevchenko