2023-08-09 03:06:32

by Ratheesh Kannoth

Subject: [PATCH net-next] page_pool: Set page pool size.

https://lore.kernel.org/netdev/
[email protected]/T/

Suggested-by: Alexander Lobakin <[email protected]>
Signed-off-by: Ratheesh Kannoth <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index 8336cea16aff..2986e238104e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -1434,7 +1434,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id,
}

pp_params.flags = PP_FLAG_PAGE_FRAG | PP_FLAG_DMA_MAP;
- pp_params.pool_size = numptrs;
+#define OTX2_PAGE_POOL_SIZE 2048
+ pp_params.pool_size = OTX2_PAGE_POOL_SIZE;
pp_params.nid = NUMA_NO_NODE;
pp_params.dev = pfvf->dev;
pp_params.dma_dir = DMA_FROM_DEVICE;
--
2.25.1

2023-08-09 07:29:48

by Ratheesh Kannoth

Subject: RE: [PATCH net-next] page_pool: Set page pool size.

> From: Ratheesh Kannoth <[email protected]>
> Sent: Wednesday, August 9, 2023 7:49 AM
> Subject: [PATCH net-next] page_pool: Set page pool size.
Please ignore/abandon the patch. Will push a new patch to "net" as it is a fix in the driver.

-Ratheesh

2023-08-14 09:26:18

by Jesper Dangaard Brouer

Subject: Re: [PATCH net-next] page_pool: Set page pool size.

On 09/08/2023 04.19, Ratheesh Kannoth wrote:
> https://lore.kernel.org/netdev/
> [email protected]/T/
>

For the record I like this code change better than changing page_pool
core code. I like and agree with Olek's (Alexander Lobakin) suggestion.

But the commit message need to be improved as it is too thin.
(And link is getting split in two lines for some reason)

> Suggested-by: Alexander Lobakin <[email protected]>
> Signed-off-by: Ratheesh Kannoth <[email protected]>
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> index 8336cea16aff..2986e238104e 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> @@ -1434,7 +1434,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id,
> }
>
> pp_params.flags = PP_FLAG_PAGE_FRAG | PP_FLAG_DMA_MAP;
> - pp_params.pool_size = numptrs;
> +#define OTX2_PAGE_POOL_SIZE 2048
> + pp_params.pool_size = OTX2_PAGE_POOL_SIZE;
> pp_params.nid = NUMA_NO_NODE;
> pp_params.dev = pfvf->dev;
> pp_params.dma_dir = DMA_FROM_DEVICE;