2023-08-08 23:16:04

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 1/1] iio: accel: msa311: Use correct header(s) instead of string_helpers.h

There is nothing from string_helpers.h used in the driver, correct
the header inclusion block accordingly.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/iio/accel/msa311.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/msa311.c b/drivers/iio/accel/msa311.c
index 6ddcc3c2f840..b8ddbfd98f11 100644
--- a/drivers/iio/accel/msa311.c
+++ b/drivers/iio/accel/msa311.c
@@ -33,7 +33,7 @@
#include <linux/pm.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
-#include <linux/string_helpers.h>
+#include <linux/string_choices.h>
#include <linux/units.h>

#include <linux/iio/buffer.h>
--
2.40.0.1.gaa8946217a0b



2023-08-09 07:43:17

by Dmitry Rokosov

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] iio: accel: msa311: Use correct header(s) instead of string_helpers.h

Hello Andy,

Thank you for the patch!

On Tue, Aug 08, 2023 at 07:41:52PM +0300, Andy Shevchenko wrote:
> There is nothing from string_helpers.h used in the driver, correct
> the header inclusion block accordingly.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Dmitry Rokosov <[email protected]>

> ---
> drivers/iio/accel/msa311.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/msa311.c b/drivers/iio/accel/msa311.c
> index 6ddcc3c2f840..b8ddbfd98f11 100644
> --- a/drivers/iio/accel/msa311.c
> +++ b/drivers/iio/accel/msa311.c
> @@ -33,7 +33,7 @@
> #include <linux/pm.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> -#include <linux/string_helpers.h>
> +#include <linux/string_choices.h>
> #include <linux/units.h>
>
> #include <linux/iio/buffer.h>
> --
> 2.40.0.1.gaa8946217a0b
>

--
Thank you,
Dmitry