2023-08-09 03:14:37

by Kemeng Shi

Subject: [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark

Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.

Signed-off-by: Kemeng Shi <[email protected]>
---
mm/compaction.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index ea61922a1619..38c8d216c6a3 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2142,7 +2142,7 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat)
return score;
}

-static unsigned int fragmentation_score_wmark(pg_data_t *pgdat, bool low)
+static unsigned int fragmentation_score_wmark(bool low)
{
unsigned int wmark_low;

@@ -2162,7 +2162,7 @@ static bool should_proactive_compact_node(pg_data_t *pgdat)
if (!sysctl_compaction_proactiveness || kswapd_is_running(pgdat))
return false;

- wmark_high = fragmentation_score_wmark(pgdat, false);
+ wmark_high = fragmentation_score_wmark(false);
return fragmentation_score_node(pgdat) > wmark_high;
}

@@ -2201,7 +2201,7 @@ static enum compact_result __compact_finished(struct compact_control *cc)
return COMPACT_PARTIAL_SKIPPED;

score = fragmentation_score_zone(cc->zone);
- wmark_low = fragmentation_score_wmark(pgdat, true);
+ wmark_low = fragmentation_score_wmark(true);

if (score > wmark_low)
ret = COMPACT_CONTINUE;
--
2.30.0

2023-08-09 09:51:41

by David Hildenbrand

Subject: Re: [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark

On 09.08.23 11:49, Kemeng Shi wrote:
> Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.
>
> Signed-off-by: Kemeng Shi <[email protected]>
> ---

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb

2023-08-09 12:51:56

by Mel Gorman

Subject: Re: [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark

On Wed, Aug 09, 2023 at 05:49:10PM +0800, Kemeng Shi wrote:
> Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.
>
> Signed-off-by: Kemeng Shi <[email protected]>

Acked-by: Mel Gorman <[email protected]>

--
Mel Gorman
SUSE Labs

2023-08-15 12:49:41

by Baolin Wang

Subject: Re: [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark

On 8/9/2023 5:49 PM, Kemeng Shi wrote:
> Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.
>
> Signed-off-by: Kemeng Shi <[email protected]>

Reviewed-by: Baolin Wang <[email protected]>

> ---
> mm/compaction.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index ea61922a1619..38c8d216c6a3 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -2142,7 +2142,7 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat)
> return score;
> }
>
> -static unsigned int fragmentation_score_wmark(pg_data_t *pgdat, bool low)
> +static unsigned int fragmentation_score_wmark(bool low)
> {
> unsigned int wmark_low;
>
> @@ -2162,7 +2162,7 @@ static bool should_proactive_compact_node(pg_data_t *pgdat)
> if (!sysctl_compaction_proactiveness || kswapd_is_running(pgdat))
> return false;
>
> - wmark_high = fragmentation_score_wmark(pgdat, false);
> + wmark_high = fragmentation_score_wmark(false);
> return fragmentation_score_node(pgdat) > wmark_high;
> }
>
> @@ -2201,7 +2201,7 @@ static enum compact_result __compact_finished(struct compact_control *cc)
> return COMPACT_PARTIAL_SKIPPED;
>
> score = fragmentation_score_zone(cc->zone);
> - wmark_low = fragmentation_score_wmark(pgdat, true);
> + wmark_low = fragmentation_score_wmark(true);
>
> if (score > wmark_low)
> ret = COMPACT_CONTINUE;