2023-08-09 18:08:46

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH net-next v3 09/10] dt-bindings: net: snps,dwmac: add per channel irq support

The IP supports per channel interrupt, add support for this usage case.

Signed-off-by: Jisheng Zhang <[email protected]>
---
.../devicetree/bindings/net/snps,dwmac.yaml | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 5d81042f5634..5a63302ad200 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -109,6 +109,7 @@ properties:
- description: The interrupt that occurs when Rx exits the LPI state
- description: The interrupt that occurs when Safety Feature Correctible Errors happen
- description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen
+ - description: All of the rx/tx per-channel interrupts

interrupt-names:
minItems: 1
@@ -118,6 +119,38 @@ properties:
- const: eth_lpi
- const: sfty_ce
- const: sfty_ue
+ - const: rx0
+ - const: rx1
+ - const: rx2
+ - const: rx3
+ - const: rx4
+ - const: rx5
+ - const: rx6
+ - const: rx7
+ - const: rx8
+ - const: rx9
+ - const: rx10
+ - const: rx11
+ - const: rx12
+ - const: rx13
+ - const: rx14
+ - const: rx15
+ - const: tx0
+ - const: tx1
+ - const: tx2
+ - const: tx3
+ - const: tx4
+ - const: tx5
+ - const: tx6
+ - const: tx7
+ - const: tx8
+ - const: tx9
+ - const: tx10
+ - const: tx11
+ - const: tx12
+ - const: tx13
+ - const: tx14
+ - const: tx15

clocks:
minItems: 1
--
2.40.1



2023-08-09 18:18:45

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH net-next v3 09/10] dt-bindings: net: snps,dwmac: add per channel irq support

On Thu, Aug 10, 2023 at 12:50:06AM +0800, Jisheng Zhang wrote:
> The IP supports per channel interrupt, add support for this usage case.
>
> Signed-off-by: Jisheng Zhang <[email protected]>

I do not see a response to
<https://lore.kernel.org/all/20230808-clapper-corncob-0af7afa65752@spud/>
in my mailbox or on lore, nor is there any changes in v3 on this front.

Thanks,
Conor.

> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 5d81042f5634..5a63302ad200 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -109,6 +109,7 @@ properties:
> - description: The interrupt that occurs when Rx exits the LPI state
> - description: The interrupt that occurs when Safety Feature Correctible Errors happen
> - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen
> + - description: All of the rx/tx per-channel interrupts
>
> interrupt-names:
> minItems: 1
> @@ -118,6 +119,38 @@ properties:
> - const: eth_lpi
> - const: sfty_ce
> - const: sfty_ue
> + - const: rx0
> + - const: rx1
> + - const: rx2
> + - const: rx3
> + - const: rx4
> + - const: rx5
> + - const: rx6
> + - const: rx7
> + - const: rx8
> + - const: rx9
> + - const: rx10
> + - const: rx11
> + - const: rx12
> + - const: rx13
> + - const: rx14
> + - const: rx15
> + - const: tx0
> + - const: tx1
> + - const: tx2
> + - const: tx3
> + - const: tx4
> + - const: tx5
> + - const: tx6
> + - const: tx7
> + - const: tx8
> + - const: tx9
> + - const: tx10
> + - const: tx11
> + - const: tx12
> + - const: tx13
> + - const: tx14
> + - const: tx15
>
> clocks:
> minItems: 1
> --
> 2.40.1
>


Attachments:
(No filename) (2.11 kB)
signature.asc (235.00 B)
Download all attachments

2023-08-10 16:37:58

by Jisheng Zhang

[permalink] [raw]
Subject: Re: [PATCH net-next v3 09/10] dt-bindings: net: snps,dwmac: add per channel irq support

On Wed, Aug 09, 2023 at 06:38:36PM +0100, Conor Dooley wrote:
> On Thu, Aug 10, 2023 at 12:50:06AM +0800, Jisheng Zhang wrote:
> > The IP supports per channel interrupt, add support for this usage case.
> >
> > Signed-off-by: Jisheng Zhang <[email protected]>
>
> I do not see a response to
> <https://lore.kernel.org/all/20230808-clapper-corncob-0af7afa65752@spud/>
> in my mailbox or on lore, nor is there any changes in v3 on this front.

oops, sorry, I didn't mbsync to fetch my inbox before sending out v3, so
I missed your review comments ;)

I will reply in the thread
>
> Thanks,
> Conor.
>
> > ---
> > .../devicetree/bindings/net/snps,dwmac.yaml | 33 +++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index 5d81042f5634..5a63302ad200 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -109,6 +109,7 @@ properties:
> > - description: The interrupt that occurs when Rx exits the LPI state
> > - description: The interrupt that occurs when Safety Feature Correctible Errors happen
> > - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen
> > + - description: All of the rx/tx per-channel interrupts
> >
> > interrupt-names:
> > minItems: 1
> > @@ -118,6 +119,38 @@ properties:
> > - const: eth_lpi
> > - const: sfty_ce
> > - const: sfty_ue
> > + - const: rx0
> > + - const: rx1
> > + - const: rx2
> > + - const: rx3
> > + - const: rx4
> > + - const: rx5
> > + - const: rx6
> > + - const: rx7
> > + - const: rx8
> > + - const: rx9
> > + - const: rx10
> > + - const: rx11
> > + - const: rx12
> > + - const: rx13
> > + - const: rx14
> > + - const: rx15
> > + - const: tx0
> > + - const: tx1
> > + - const: tx2
> > + - const: tx3
> > + - const: tx4
> > + - const: tx5
> > + - const: tx6
> > + - const: tx7
> > + - const: tx8
> > + - const: tx9
> > + - const: tx10
> > + - const: tx11
> > + - const: tx12
> > + - const: tx13
> > + - const: tx14
> > + - const: tx15
> >
> > clocks:
> > minItems: 1
> > --
> > 2.40.1
> >