2023-08-10 01:41:52

by Hari Nagalla

[permalink] [raw]
Subject: [PATCH] arm64: dts: ti: k3-j784s4-main: disable remote proc nodes

Disable the dsp and r5f subsystem nodes by default. Proper functioning
of remote processors with ipc need mailbox configurations which can
vary between board configurations and applications. Hence move enabling
the remote processor device nodes to where the required configurations
are complete.

Signed-off-by: Hari Nagalla <[email protected]>
---
This patch fixes the remote proc yamllint errors for am69-sk board

arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
index a04c44708a09..e7b54338b220 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
@@ -1402,6 +1402,7 @@ main_r5fss0: r5fss@5c00000 {
ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
<0x5d00000 0x00 0x5d00000 0x20000>;
power-domains = <&k3_pds 336 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";

main_r5fss0_core0: r5f@5c00000 {
compatible = "ti,j721s2-r5f";
@@ -1442,6 +1443,7 @@ main_r5fss1: r5fss@5e00000 {
ranges = <0x5e00000 0x00 0x5e00000 0x20000>,
<0x5f00000 0x00 0x5f00000 0x20000>;
power-domains = <&k3_pds 337 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";

main_r5fss1_core0: r5f@5e00000 {
compatible = "ti,j721s2-r5f";
@@ -1482,6 +1484,7 @@ main_r5fss2: r5fss@5900000 {
ranges = <0x5900000 0x00 0x5900000 0x20000>,
<0x5a00000 0x00 0x5a00000 0x20000>;
power-domains = <&k3_pds 338 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";

main_r5fss2_core0: r5f@5900000 {
compatible = "ti,j721s2-r5f";
@@ -1524,6 +1527,7 @@ c71_0: dsp@64800000 {
ti,sci-proc-ids = <0x30 0xff>;
resets = <&k3_reset 30 1>;
firmware-name = "j784s4-c71_0-fw";
+ status = "disabled";
};

c71_1: dsp@65800000 {
@@ -1536,6 +1540,7 @@ c71_1: dsp@65800000 {
ti,sci-proc-ids = <0x31 0xff>;
resets = <&k3_reset 33 1>;
firmware-name = "j784s4-c71_1-fw";
+ status = "disabled";
};

c71_2: dsp@66800000 {
@@ -1548,6 +1553,7 @@ c71_2: dsp@66800000 {
ti,sci-proc-ids = <0x32 0xff>;
resets = <&k3_reset 37 1>;
firmware-name = "j784s4-c71_2-fw";
+ status = "disabled";
};

c71_3: dsp@67800000 {
@@ -1560,5 +1566,6 @@ c71_3: dsp@67800000 {
ti,sci-proc-ids = <0x33 0xff>;
resets = <&k3_reset 40 1>;
firmware-name = "j784s4-c71_3-fw";
+ status = "disabled";
};
};
--
2.34.1



2023-08-10 02:36:37

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-main: disable remote proc nodes

On 19:56-20230809, Hari Nagalla wrote:
> Disable the dsp and r5f subsystem nodes by default. Proper functioning
> of remote processors with ipc need mailbox configurations which can
> vary between board configurations and applications. Hence move enabling
> the remote processor device nodes to where the required configurations
> are complete.
>
> Signed-off-by: Hari Nagalla <[email protected]>
> ---
> This patch fixes the remote proc yamllint errors for am69-sk board

Fixes tag?
>
> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index a04c44708a09..e7b54338b220 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -1402,6 +1402,7 @@ main_r5fss0: r5fss@5c00000 {
> ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
> <0x5d00000 0x00 0x5d00000 0x20000>;
> power-domains = <&k3_pds 336 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
>
> main_r5fss0_core0: r5f@5c00000 {
> compatible = "ti,j721s2-r5f";
> @@ -1442,6 +1443,7 @@ main_r5fss1: r5fss@5e00000 {
> ranges = <0x5e00000 0x00 0x5e00000 0x20000>,
> <0x5f00000 0x00 0x5f00000 0x20000>;
> power-domains = <&k3_pds 337 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
>
> main_r5fss1_core0: r5f@5e00000 {
> compatible = "ti,j721s2-r5f";
> @@ -1482,6 +1484,7 @@ main_r5fss2: r5fss@5900000 {
> ranges = <0x5900000 0x00 0x5900000 0x20000>,
> <0x5a00000 0x00 0x5a00000 0x20000>;
> power-domains = <&k3_pds 338 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
>
> main_r5fss2_core0: r5f@5900000 {
> compatible = "ti,j721s2-r5f";
> @@ -1524,6 +1527,7 @@ c71_0: dsp@64800000 {
> ti,sci-proc-ids = <0x30 0xff>;
> resets = <&k3_reset 30 1>;
> firmware-name = "j784s4-c71_0-fw";
> + status = "disabled";
> };
>
> c71_1: dsp@65800000 {
> @@ -1536,6 +1540,7 @@ c71_1: dsp@65800000 {
> ti,sci-proc-ids = <0x31 0xff>;
> resets = <&k3_reset 33 1>;
> firmware-name = "j784s4-c71_1-fw";
> + status = "disabled";
> };
>
> c71_2: dsp@66800000 {
> @@ -1548,6 +1553,7 @@ c71_2: dsp@66800000 {
> ti,sci-proc-ids = <0x32 0xff>;
> resets = <&k3_reset 37 1>;
> firmware-name = "j784s4-c71_2-fw";
> + status = "disabled";
> };
>
> c71_3: dsp@67800000 {
> @@ -1560,5 +1566,6 @@ c71_3: dsp@67800000 {
> ti,sci-proc-ids = <0x33 0xff>;
> resets = <&k3_reset 40 1>;
> firmware-name = "j784s4-c71_3-fw";
> + status = "disabled";
> };
> };
> --
> 2.34.1
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2023-08-10 18:25:37

by Hari Nagalla

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-main: disable remote proc nodes

On 8/9/23 20:10, Nishanth Menon wrote:
>> Disable the dsp and r5f subsystem nodes by default. Proper functioning
>> of remote processors with ipc need mailbox configurations which can
>> vary between board configurations and applications. Hence move enabling
>> the remote processor device nodes to where the required configurations
>> are complete.
>>
>> Signed-off-by: Hari Nagalla<[email protected]>
>> ---
>> This patch fixes the remote proc yamllint errors for am69-sk board
> Fixes tag?
As such this yamllint errors for am69-sk.dtb were present in several
earlier tags of linux-next. Checked with latest tag: next-20230809.

Please let me know if you would need v2 with the tag specified in comments.

/home/a0868345/git/upstream/linux-next/arch/arm64/boot/dts/ti/k3-am69-sk.dtb:
dsp@64800000: 'mboxes' is a required property
from schema $id:
http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
/home/a0868345/git/upstream/linux-next/arch/arm64/boot/dts/ti/k3-am69-sk.dtb:
dsp@64800000: 'memory-region' is a required property
from schema $id:
http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
/home/a0868345/git/upstream/linux-next/arch/arm64/boot/dts/ti/k3-am69-sk.dtb:
dsp@65800000: 'mboxes' is a required property
from schema $id:
http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
/home/a0868345/git/upstream/linux-next/arch/arm64/boot/dts/ti/k3-am69-sk.dtb:
dsp@65800000: 'memory-region' is a required property
from schema $id:
http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
/home/a0868345/git/upstream/linux-next/arch/arm64/boot/dts/ti/k3-am69-sk.dtb:
dsp@66800000: 'mboxes' is a required property
from schema $id:
http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
/home/a0868345/git/upstream/linux-next/arch/arm64/boot/dts/ti/k3-am69-sk.dtb:
dsp@66800000: 'memory-region' is a required property
from schema $id:
http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
/home/a0868345/git/upstream/linux-next/arch/arm64/boot/dts/ti/k3-am69-sk.dtb:
dsp@67800000: 'mboxes' is a required property
from schema $id:
http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
/home/a0868345/git/upstream/linux-next/arch/arm64/boot/dts/ti/k3-am69-sk.dtb:
dsp@67800000: 'memory-region' is a required property
from schema $id:
http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#


2023-08-10 18:47:22

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-main: disable remote proc nodes

On 10:38-20230810, Hari Nagalla wrote:
> On 8/9/23 20:10, Nishanth Menon wrote:
> > > Disable the dsp and r5f subsystem nodes by default. Proper functioning
> > > of remote processors with ipc need mailbox configurations which can
> > > vary between board configurations and applications. Hence move enabling
> > > the remote processor device nodes to where the required configurations
> > > are complete.
> > >
> > > Signed-off-by: Hari Nagalla<[email protected]>
> > > ---
> > > This patch fixes the remote proc yamllint errors for am69-sk board
> > Fixes tag?
> As such this yamllint errors for am69-sk.dtb were present in several earlier
> tags of linux-next. Checked with latest tag: next-20230809.
>
> Please let me know if you would need v2 with the tag specified in comments.
>

Please rebase on
https://lore.kernel.org/all/[email protected]/
series.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D