2023-08-02 16:37:15

by Cyril Hrubis

[permalink] [raw]
Subject: [PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice

- Fixes rounding error for initial value with CONFIG_HZ_300

- Fixes read from the file after reset to default (by writing val <= 0)

Cyril Hrubis (2):
sched/rt: Fix sysctl_sched_rr_timeslice intial value
sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset

kernel/sched/rt.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

--
2.41.0



2023-08-10 09:36:33

by Mel Gorman

[permalink] [raw]
Subject: Re: [PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice

On Wed, Aug 02, 2023 at 05:19:04PM +0200, Cyril Hrubis wrote:
> - Fixes rounding error for initial value with CONFIG_HZ_300
>
> - Fixes read from the file after reset to default (by writing val <= 0)
>

Hi Peter,

Any chance this can be picked up in tip please? It might have helped if
the leader mentioned the main problem covered in patch 1 -- some HZ
values can fail LTP tests due to a simple rounding error at compile
time.

--
Mel Gorman
SUSE Labs

2023-08-10 12:21:02

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice

On Thu, Aug 10, 2023 at 09:30:28AM +0100, Mel Gorman wrote:
> On Wed, Aug 02, 2023 at 05:19:04PM +0200, Cyril Hrubis wrote:
> > - Fixes rounding error for initial value with CONFIG_HZ_300
> >
> > - Fixes read from the file after reset to default (by writing val <= 0)
> >
>
> Hi Peter,
>
> Any chance this can be picked up in tip please? It might have helped if
> the leader mentioned the main problem covered in patch 1 -- some HZ
> values can fail LTP tests due to a simple rounding error at compile
> time.

Yah, sorry, too much crazy atm :/ Got it queued.