2023-08-10 10:35:00

by Krzysztof Kozlowski

Subject: [PATCH 2/9] mfd: max14577: Fix Wvoid-pointer-to-enum-cast warning

'dev_type' is an enum, thus cast of pointer on 64-bit compile test with
W=1 causes:

max14577.c:406:5: error: cast to smaller integer type 'enum maxim_device_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/mfd/max14577.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index 25ed8846b7fb..1f4f5002595c 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -402,8 +402,7 @@ static int max14577_i2c_probe(struct i2c_client *i2c)

of_id = of_match_device(max14577_dt_match, &i2c->dev);
if (of_id)
- max14577->dev_type =
- (enum maxim_device_type)of_id->data;
+ max14577->dev_type = (uintptr_t)of_id->data;
} else {
max14577->dev_type = id->driver_data;
}
--
2.34.1

2023-08-10 15:10:25

by Chanwoo Choi

Subject: Re: [PATCH 2/9] mfd: max14577: Fix Wvoid-pointer-to-enum-cast warning

On 23. 8. 10. 18:58, Krzysztof Kozlowski wrote:
> 'dev_type' is an enum, thus cast of pointer on 64-bit compile test with
> W=1 causes:
>
> max14577.c:406:5: error: cast to smaller integer type 'enum maxim_device_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/mfd/max14577.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> index 25ed8846b7fb..1f4f5002595c 100644
> --- a/drivers/mfd/max14577.c
> +++ b/drivers/mfd/max14577.c
> @@ -402,8 +402,7 @@ static int max14577_i2c_probe(struct i2c_client *i2c)
>
> of_id = of_match_device(max14577_dt_match, &i2c->dev);
> if (of_id)
> - max14577->dev_type =
> - (enum maxim_device_type)of_id->data;
> + max14577->dev_type = (uintptr_t)of_id->data;
> } else {
> max14577->dev_type = id->driver_data;
> }

Reviewed-by: Chanwoo Choi <[email protected]>

--
Best Regards,
Samsung Electronics
Chanwoo Choi