2023-08-10 15:42:10

by Yue Haibing

Subject: [PATCH -next] tee: Remove unused declarations

Commit 4fb0a5eb364d ("tee: add OP-TEE driver") declared but never implemented
optee_supp_read()/optee_supp_write().
Commit 967c9cca2cc5 ("tee: generic TEE subsystem") never implemented tee_shm_init().

Signed-off-by: Yue Haibing <[email protected]>
---
drivers/tee/optee/optee_private.h | 2 --
drivers/tee/tee_private.h | 2 --
2 files changed, 4 deletions(-)

diff --git a/drivers/tee/optee/optee_private.h b/drivers/tee/optee/optee_private.h
index 72685ee0d53f..6bb5cae09688 100644
--- a/drivers/tee/optee/optee_private.h
+++ b/drivers/tee/optee/optee_private.h
@@ -238,8 +238,6 @@ int optee_notif_send(struct optee *optee, u_int key);
u32 optee_supp_thrd_req(struct tee_context *ctx, u32 func, size_t num_params,
struct tee_param *param);

-int optee_supp_read(struct tee_context *ctx, void __user *buf, size_t len);
-int optee_supp_write(struct tee_context *ctx, void __user *buf, size_t len);
void optee_supp_init(struct optee_supp *supp);
void optee_supp_uninit(struct optee_supp *supp);
void optee_supp_release(struct optee_supp *supp);
diff --git a/drivers/tee/tee_private.h b/drivers/tee/tee_private.h
index 409cadcc1cff..754e11dcb240 100644
--- a/drivers/tee/tee_private.h
+++ b/drivers/tee/tee_private.h
@@ -47,8 +47,6 @@ struct tee_device {
struct tee_shm_pool *pool;
};

-int tee_shm_init(void);
-
int tee_shm_get_fd(struct tee_shm *shm);

bool tee_device_get(struct tee_device *teedev);
--
2.34.1

2023-09-13 09:42:58

by Jens Wiklander

Subject: Re: [PATCH -next] tee: Remove unused declarations

On Thu, Aug 17, 2023 at 12:11 PM Sumit Garg <[email protected]> wrote:
>
> On Thu, 10 Aug 2023 at 20:19, Yue Haibing <[email protected]> wrote:
> >
> > Commit 4fb0a5eb364d ("tee: add OP-TEE driver") declared but never implemented
> > optee_supp_read()/optee_supp_write().
> > Commit 967c9cca2cc5 ("tee: generic TEE subsystem") never implemented tee_shm_init().
> >
> > Signed-off-by: Yue Haibing <[email protected]>
> > ---
> > drivers/tee/optee/optee_private.h | 2 --
> > drivers/tee/tee_private.h | 2 --
> > 2 files changed, 4 deletions(-)
> >
>
> Reviewed-by: Sumit Garg <[email protected]>

I'm picking up this.

Thanks,
Jens

>
> -Sumit
>
> > diff --git a/drivers/tee/optee/optee_private.h b/drivers/tee/optee/optee_private.h
> > index 72685ee0d53f..6bb5cae09688 100644
> > --- a/drivers/tee/optee/optee_private.h
> > +++ b/drivers/tee/optee/optee_private.h
> > @@ -238,8 +238,6 @@ int optee_notif_send(struct optee *optee, u_int key);
> > u32 optee_supp_thrd_req(struct tee_context *ctx, u32 func, size_t num_params,
> > struct tee_param *param);
> >
> > -int optee_supp_read(struct tee_context *ctx, void __user *buf, size_t len);
> > -int optee_supp_write(struct tee_context *ctx, void __user *buf, size_t len);
> > void optee_supp_init(struct optee_supp *supp);
> > void optee_supp_uninit(struct optee_supp *supp);
> > void optee_supp_release(struct optee_supp *supp);
> > diff --git a/drivers/tee/tee_private.h b/drivers/tee/tee_private.h
> > index 409cadcc1cff..754e11dcb240 100644
> > --- a/drivers/tee/tee_private.h
> > +++ b/drivers/tee/tee_private.h
> > @@ -47,8 +47,6 @@ struct tee_device {
> > struct tee_shm_pool *pool;
> > };
> >
> > -int tee_shm_init(void);
> > -
> > int tee_shm_get_fd(struct tee_shm *shm);
> >
> > bool tee_device_get(struct tee_device *teedev);
> > --
> > 2.34.1
> >