2023-08-11 11:17:37

by Martin Botka

[permalink] [raw]
Subject: [PATCH 0/3] Enable Security ID for H616

Hello,

This patch series enables Security ID (SID) support for AllWinner H616.

SID support is an requirement for few things:
- Thermal sensors
- CPU Binning ID (cpufreq will use this)
- EPhy

This patch series doesn't add support for the consumers.
Those will come in the future via their own series.

Cheers,
Martin

Signed-off-by: Martin Botka <[email protected]>
---
Martin Botka (3):
dt-bindings: nvmem: SID: Add binding for H616 SID controller
nvmem: sunxi_sid: Add support for H616 SID
arm64: dts: allwinner: h616: Add SID controller node

.../devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 +
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 7 +++++++
drivers/nvmem/sunxi_sid.c | 1 +
3 files changed, 9 insertions(+)
---
base-commit: 52a93d39b17dc7eb98b6aa3edb93943248e03b2f
change-id: 20230811-sid-h616-37b773e59571

Best regards,
--
Martin Botka <[email protected]>



2023-08-11 11:20:43

by Martin Botka

[permalink] [raw]
Subject: [PATCH 1/3] dt-bindings: nvmem: SID: Add binding for H616 SID controller

Add binding for the SID controller found in H616 SoC

Signed-off-by: Martin Botka <[email protected]>
---
Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
index 296001e7f498..2ec0a1b8f803 100644
--- a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
+++ b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
@@ -27,6 +27,7 @@ properties:
- const: allwinner,sun50i-a64-sid
- const: allwinner,sun50i-h5-sid
- const: allwinner,sun50i-h6-sid
+ - const: allwinner,sun50i-h616-sid

reg:
maxItems: 1

--
2.41.0


2023-08-11 11:22:12

by Martin Botka

[permalink] [raw]
Subject: [PATCH 3/3] arm64: dts: allwinner: h616: Add SID controller node

Add node for the H616 SID controller

Signed-off-by: Martin Botka <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
index 74aed0d232a9..5c5187a22537 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
@@ -133,6 +133,13 @@ ccu: clock@3001000 {
#reset-cells = <1>;
};

+ sid: efuse@3006000 {
+ compatible = "allwinner,sun50i-h616-sid";
+ reg = <0x03006000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
watchdog: watchdog@30090a0 {
compatible = "allwinner,sun50i-h616-wdt",
"allwinner,sun6i-a31-wdt";

--
2.41.0


2023-08-11 11:47:03

by Martin Botka

[permalink] [raw]
Subject: [PATCH 2/3] nvmem: sunxi_sid: Add support for H616 SID

Add support for the H616 SID controller.

The config can be reused from A64.

Signed-off-by: Martin Botka <[email protected]>
---
drivers/nvmem/sunxi_sid.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c
index a970f1741cc6..df6fb5e0b724 100644
--- a/drivers/nvmem/sunxi_sid.c
+++ b/drivers/nvmem/sunxi_sid.c
@@ -216,6 +216,7 @@ static const struct of_device_id sunxi_sid_of_match[] = {
{ .compatible = "allwinner,sun50i-a64-sid", .data = &sun50i_a64_cfg },
{ .compatible = "allwinner,sun50i-h5-sid", .data = &sun50i_a64_cfg },
{ .compatible = "allwinner,sun50i-h6-sid", .data = &sun50i_h6_cfg },
+ { .compatible = "allwinner,sun50i-h616-sid", .data = &sun50i_a64_cfg },
{/* sentinel */},
};
MODULE_DEVICE_TABLE(of, sunxi_sid_of_match);

--
2.41.0


2023-08-11 16:16:04

by Martin Botka

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: nvmem: SID: Add binding for H616 SID controller



On Fri, Aug 11 2023 at 04:23:11 PM +01:00:00, Conor Dooley
<[email protected]> wrote:
> On Fri, Aug 11, 2023 at 01:02:34PM +0200, Martin Botka wrote:
>> Add binding for the SID controller found in H616 SoC
>>
>> Signed-off-by: Martin Botka <[email protected]>
>> ---
>>
>> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> index 296001e7f498..2ec0a1b8f803 100644
>> ---
>> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> +++
>> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> @@ -27,6 +27,7 @@ properties:
>> - const: allwinner,sun50i-a64-sid
>> - const: allwinner,sun50i-h5-sid
>> - const: allwinner,sun50i-h6-sid
>> + - const: allwinner,sun50i-h616-sid
>
> As said by Andre, use a fallback compatible here please.

Will do.
Cheers,
Martin



2023-08-11 16:24:19

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: nvmem: SID: Add binding for H616 SID controller

On Fri, Aug 11, 2023 at 01:02:34PM +0200, Martin Botka wrote:
> Add binding for the SID controller found in H616 SoC
>
> Signed-off-by: Martin Botka <[email protected]>
> ---
> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> index 296001e7f498..2ec0a1b8f803 100644
> --- a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> @@ -27,6 +27,7 @@ properties:
> - const: allwinner,sun50i-a64-sid
> - const: allwinner,sun50i-h5-sid
> - const: allwinner,sun50i-h6-sid
> + - const: allwinner,sun50i-h616-sid

As said by Andre, use a fallback compatible here please.


Attachments:
(No filename) (936.00 B)
signature.asc (235.00 B)
Download all attachments