2023-08-11 10:12:21

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] PCI: Remove unused function declarations

These declarations is never implemented since the beginning of git history.

Signed-off-by: Yue Haibing <[email protected]>
---
drivers/pci/hotplug/acpiphp.h | 1 -
drivers/pci/hotplug/cpci_hotplug.h | 2 --
drivers/pci/hotplug/ibmphp.h | 2 --
include/linux/pci.h | 1 -
4 files changed, 6 deletions(-)

diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
index 1f8ab4377ad8..5745be6018e1 100644
--- a/drivers/pci/hotplug/acpiphp.h
+++ b/drivers/pci/hotplug/acpiphp.h
@@ -178,7 +178,6 @@ void acpiphp_unregister_hotplug_slot(struct acpiphp_slot *slot);
int acpiphp_enable_slot(struct acpiphp_slot *slot);
int acpiphp_disable_slot(struct acpiphp_slot *slot);
u8 acpiphp_get_power_status(struct acpiphp_slot *slot);
-u8 acpiphp_get_attention_status(struct acpiphp_slot *slot);
u8 acpiphp_get_latch_status(struct acpiphp_slot *slot);
u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot);

diff --git a/drivers/pci/hotplug/cpci_hotplug.h b/drivers/pci/hotplug/cpci_hotplug.h
index 3fdd1b9bd8c3..6d8970d8c3f2 100644
--- a/drivers/pci/hotplug/cpci_hotplug.h
+++ b/drivers/pci/hotplug/cpci_hotplug.h
@@ -83,8 +83,6 @@ extern int cpci_debug;
* board/chassis drivers.
*/
u8 cpci_get_attention_status(struct slot *slot);
-u8 cpci_get_latch_status(struct slot *slot);
-u8 cpci_get_adapter_status(struct slot *slot);
u16 cpci_get_hs_csr(struct slot *slot);
int cpci_set_attention_status(struct slot *slot, int status);
int cpci_check_and_clear_ins(struct slot *slot);
diff --git a/drivers/pci/hotplug/ibmphp.h b/drivers/pci/hotplug/ibmphp.h
index 0399c60d2ec1..41eafe511210 100644
--- a/drivers/pci/hotplug/ibmphp.h
+++ b/drivers/pci/hotplug/ibmphp.h
@@ -264,8 +264,6 @@ extern struct list_head ibmphp_slot_head;
void ibmphp_free_ebda_hpc_queue(void);
int ibmphp_access_ebda(void);
struct slot *ibmphp_get_slot_from_physical_num(u8);
-int ibmphp_get_total_hp_slots(void);
-void ibmphp_free_ibm_slot(struct slot *);
void ibmphp_free_bus_info_queue(void);
void ibmphp_free_ebda_pci_rsrc_queue(void);
struct bus_info *ibmphp_find_same_bus_num(u32);
diff --git a/include/linux/pci.h b/include/linux/pci.h
index eeb2e6f6130f..494470a38abf 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1403,7 +1403,6 @@ void pci_assign_unassigned_bridge_resources(struct pci_dev *bridge);
void pci_assign_unassigned_bus_resources(struct pci_bus *bus);
void pci_assign_unassigned_root_bus_resources(struct pci_bus *bus);
int pci_reassign_bridge_resources(struct pci_dev *bridge, unsigned long type);
-void pdev_enable_device(struct pci_dev *);
int pci_enable_resources(struct pci_dev *, int mask);
void pci_assign_irq(struct pci_dev *dev);
struct resource *pci_find_resource(struct pci_dev *dev, struct resource *res);
--
2.34.1



2023-08-11 17:04:04

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH -next] PCI: Remove unused function declarations

On Fri, Aug 11, 2023 at 05:59:33PM +0800, Yue Haibing wrote:
> These declarations is never implemented since the beginning of git history.
>
> Signed-off-by: Yue Haibing <[email protected]>

Applied to pci/misc for v6.6, thank you!

> ---
> drivers/pci/hotplug/acpiphp.h | 1 -
> drivers/pci/hotplug/cpci_hotplug.h | 2 --
> drivers/pci/hotplug/ibmphp.h | 2 --
> include/linux/pci.h | 1 -
> 4 files changed, 6 deletions(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> index 1f8ab4377ad8..5745be6018e1 100644
> --- a/drivers/pci/hotplug/acpiphp.h
> +++ b/drivers/pci/hotplug/acpiphp.h
> @@ -178,7 +178,6 @@ void acpiphp_unregister_hotplug_slot(struct acpiphp_slot *slot);
> int acpiphp_enable_slot(struct acpiphp_slot *slot);
> int acpiphp_disable_slot(struct acpiphp_slot *slot);
> u8 acpiphp_get_power_status(struct acpiphp_slot *slot);
> -u8 acpiphp_get_attention_status(struct acpiphp_slot *slot);
> u8 acpiphp_get_latch_status(struct acpiphp_slot *slot);
> u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot);
>
> diff --git a/drivers/pci/hotplug/cpci_hotplug.h b/drivers/pci/hotplug/cpci_hotplug.h
> index 3fdd1b9bd8c3..6d8970d8c3f2 100644
> --- a/drivers/pci/hotplug/cpci_hotplug.h
> +++ b/drivers/pci/hotplug/cpci_hotplug.h
> @@ -83,8 +83,6 @@ extern int cpci_debug;
> * board/chassis drivers.
> */
> u8 cpci_get_attention_status(struct slot *slot);
> -u8 cpci_get_latch_status(struct slot *slot);
> -u8 cpci_get_adapter_status(struct slot *slot);
> u16 cpci_get_hs_csr(struct slot *slot);
> int cpci_set_attention_status(struct slot *slot, int status);
> int cpci_check_and_clear_ins(struct slot *slot);
> diff --git a/drivers/pci/hotplug/ibmphp.h b/drivers/pci/hotplug/ibmphp.h
> index 0399c60d2ec1..41eafe511210 100644
> --- a/drivers/pci/hotplug/ibmphp.h
> +++ b/drivers/pci/hotplug/ibmphp.h
> @@ -264,8 +264,6 @@ extern struct list_head ibmphp_slot_head;
> void ibmphp_free_ebda_hpc_queue(void);
> int ibmphp_access_ebda(void);
> struct slot *ibmphp_get_slot_from_physical_num(u8);
> -int ibmphp_get_total_hp_slots(void);
> -void ibmphp_free_ibm_slot(struct slot *);
> void ibmphp_free_bus_info_queue(void);
> void ibmphp_free_ebda_pci_rsrc_queue(void);
> struct bus_info *ibmphp_find_same_bus_num(u32);
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index eeb2e6f6130f..494470a38abf 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1403,7 +1403,6 @@ void pci_assign_unassigned_bridge_resources(struct pci_dev *bridge);
> void pci_assign_unassigned_bus_resources(struct pci_bus *bus);
> void pci_assign_unassigned_root_bus_resources(struct pci_bus *bus);
> int pci_reassign_bridge_resources(struct pci_dev *bridge, unsigned long type);
> -void pdev_enable_device(struct pci_dev *);
> int pci_enable_resources(struct pci_dev *, int mask);
> void pci_assign_irq(struct pci_dev *dev);
> struct resource *pci_find_resource(struct pci_dev *dev, struct resource *res);
> --
> 2.34.1
>