2023-08-11 22:13:37

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH 0/7] Initial support for MSM8x26 Lumias

Hello,

The following patches:
- Add device tree files for Nokia/Microsoft Lumia phones based around
the MSM8x26 family of Qualcomm chipsets, utilising a common tree
- Document this support

Rayyan Ansari (7):
dt-bindings: arm: qcom: Document MSM8x26-based Lumia phones
ARM: dts: qcom: add common device tree for MSM8x26-based Lumia phones
ARM: dts: qcom: add device tree for Nokia Lumia 630
ARM: dts: qcom: add device tree for Microsoft Lumia 640
ARM: dts: qcom: add device tree for Microsoft Lumia 640 XL
ARM: dts: qcom: add device tree for Nokia Lumia 735
ARM: dts: qcom: add device tree for Nokia Lumia 830

.../devicetree/bindings/arm/qcom.yaml | 9 +
arch/arm/boot/dts/qcom/Makefile | 5 +
.../qcom/qcom-msm8226-microsoft-common.dtsi | 332 ++++++++++++++++++
.../qcom/qcom-msm8226-microsoft-dempsey.dts | 17 +
.../qcom/qcom-msm8226-microsoft-makepeace.dts | 17 +
.../qcom-msm8226-microsoft-moneypenny.dts | 23 ++
.../qcom-msm8926-microsoft-superman-lte.dts | 52 +++
.../dts/qcom/qcom-msm8926-microsoft-tesla.dts | 66 ++++
8 files changed, 521 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-dempsey.dts
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-makepeace.dts
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts

--
2.41.0



2023-08-11 22:15:16

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH 5/7] ARM: dts: qcom: add device tree for Microsoft Lumia 640 XL

Add an initial device tree for the Microsoft Lumia 640 XL, codenamed
"makepeace".

Co-authored-by: Dominik Kobinski <[email protected]>
Co-authored-by: Ivaylo Ivanov <[email protected]>
Co-authored-by: Jack Matthews <[email protected]>
Signed-off-by: Dominik Kobinski <[email protected]>
Signed-off-by: Ivaylo Ivanov <[email protected]>
Signed-off-by: Jack Matthews <[email protected]>
Signed-off-by: Rayyan Ansari <[email protected]>
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom/qcom-msm8226-microsoft-makepeace.dts | 17 +++++++++++++++++
2 files changed, 18 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-makepeace.dts

diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index 13896c6974f6..487e0a5987ce 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -24,6 +24,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-ipq8064-ap148.dtb \
qcom-ipq8064-rb3011.dtb \
qcom-msm8226-microsoft-dempsey.dtb \
+ qcom-msm8226-microsoft-makepeace.dtb \
qcom-msm8226-microsoft-moneypenny.dtb \
qcom-msm8226-samsung-s3ve3g.dtb \
qcom-msm8660-surf.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-makepeace.dts b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-makepeace.dts
new file mode 100644
index 000000000000..731c5c375678
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-makepeace.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023, Jack Matthews <[email protected]>
+ * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
+ * Copyright (c) 2023, Dominik Kobinski <[email protected]>
+ * Copyright (c) 2023, Rayyan Ansari <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-microsoft-common.dtsi"
+
+/ {
+ model = "Microsoft Lumia 640 XL";
+ compatible = "microsoft,makepeace", "qcom,msm8226";
+ chassis-type = "handset";
+};
--
2.41.0


2023-08-11 22:21:19

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH 1/7] dt-bindings: arm: qcom: Document MSM8x26-based Lumia phones

Document MSM8226 and MSM8926 Lumias.

Signed-off-by: Rayyan Ansari <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 450f616774e0..ea4b1c530461 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -181,9 +181,18 @@ properties:

- items:
- enum:
+ - microsoft,dempsey
+ - microsoft,makepeace
+ - microsoft,moneypenny
- samsung,s3ve3g
- const: qcom,msm8226

+ - items:
+ - enum:
+ - microsoft,superman-lte
+ - microsoft,tesla
+ - const: qcom,msm8926
+
- items:
- enum:
- sony,kanuti-tulip
--
2.41.0


2023-08-11 22:21:38

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH 4/7] ARM: dts: qcom: add device tree for Microsoft Lumia 640

Add an initial device tree for the Microsoft Lumia 640, codenamed
"dempsey".

Co-authored-by: Dominik Kobinski <[email protected]>
Co-authored-by: Ivaylo Ivanov <[email protected]>
Co-authored-by: Jack Matthews <[email protected]>
Signed-off-by: Dominik Kobinski <[email protected]>
Signed-off-by: Ivaylo Ivanov <[email protected]>
Signed-off-by: Jack Matthews <[email protected]>
Signed-off-by: Rayyan Ansari <[email protected]>
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../dts/qcom/qcom-msm8226-microsoft-dempsey.dts | 17 +++++++++++++++++
2 files changed, 18 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-dempsey.dts

diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index b2569059ce8d..13896c6974f6 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-ipq4019-ap.dk07.1-c2.dtb \
qcom-ipq8064-ap148.dtb \
qcom-ipq8064-rb3011.dtb \
+ qcom-msm8226-microsoft-dempsey.dtb \
qcom-msm8226-microsoft-moneypenny.dtb \
qcom-msm8226-samsung-s3ve3g.dtb \
qcom-msm8660-surf.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-dempsey.dts b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-dempsey.dts
new file mode 100644
index 000000000000..2c664b5934ec
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-dempsey.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023, Jack Matthews <[email protected]>
+ * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
+ * Copyright (c) 2023, Dominik Kobinski <[email protected]>
+ * Copyright (c) 2023, Rayyan Ansari <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-microsoft-common.dtsi"
+
+/ {
+ model = "Microsoft Lumia 640";
+ compatible = "microsoft,dempsey", "qcom,msm8226";
+ chassis-type = "handset";
+};
--
2.41.0


2023-08-11 22:29:18

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH 7/7] ARM: dts: qcom: add device tree for Nokia Lumia 830

Add an initial device tree for the Nokia Lumia 830, codenamed
"tesla".

Co-authored-by: Dominik Kobinski <[email protected]>
Co-authored-by: Ivaylo Ivanov <[email protected]>
Co-authored-by: Jack Matthews <[email protected]>
Signed-off-by: Dominik Kobinski <[email protected]>
Signed-off-by: Ivaylo Ivanov <[email protected]>
Signed-off-by: Jack Matthews <[email protected]>
Signed-off-by: Rayyan Ansari <[email protected]>
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../dts/qcom/qcom-msm8926-microsoft-tesla.dts | 66 +++++++++++++++++++
2 files changed, 67 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts

diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index 7982620ec9f9..a3d293e40820 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8916-samsung-grandmax.dtb \
qcom-msm8916-samsung-serranove.dtb \
qcom-msm8926-microsoft-superman-lte.dtb \
+ qcom-msm8926-microsoft-tesla.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
new file mode 100644
index 000000000000..5a4f4687b895
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
@@ -0,0 +1,66 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023, Jack Matthews <[email protected]>
+ * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
+ * Copyright (c) 2023, Dominik Kobinski <[email protected]>
+ * Copyright (c) 2023, Rayyan Ansari <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-microsoft-common.dtsi"
+
+/ {
+ model = "Nokia Lumia 830";
+ compatible = "microsoft,tesla", "qcom,msm8926";
+ chassis-type = "handset";
+};
+
+&blsp1_i2c1 {
+ status = "okay";
+
+ touchscreen@4b {
+ compatible = "syna,rmi4-i2c";
+ reg = <0x4b>;
+
+ interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
+ vdd-supply = <&pm8226_l15>;
+ vio-supply = <&pm8226_l6>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&touchscreen_on>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rmi4-f01@1 {
+ reg = <0x01>;
+ syna,nosleep-mode = <1>;
+ };
+
+ rmi4-f12@12 {
+ reg = <0x12>;
+ syna,sensor-type = <1>;
+ };
+ };
+};
+
+&blsp1_i2c5 {
+ status = "disabled";
+
+ /delete-node/ touchscreen@4b;
+};
+
+&gpio_keys {
+ camera-snapshot {
+ label = "Camera Snapshot";
+ gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_CAMERA>;
+ };
+
+ camera-focus {
+ label = "Camera Focus";
+ gpios = <&tlmm 108 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_CAMERA_FOCUS>;
+ };
+};
--
2.41.0


2023-08-11 23:01:27

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH 2/7] ARM: dts: qcom: add common device tree for MSM8x26-based Lumia phones

Add a common device tree for Lumias based on the Qualcomm MSM8x26
family of chipsets.

Currently supports:
- Framebuffer
- Touchscreen
- Keys
- Regulators
- MMC
- USB
- UART

Co-authored-by: Dominik Kobinski <[email protected]>
Co-authored-by: Ivaylo Ivanov <[email protected]>
Co-authored-by: Jack Matthews <[email protected]>
Signed-off-by: Dominik Kobinski <[email protected]>
Signed-off-by: Ivaylo Ivanov <[email protected]>
Signed-off-by: Jack Matthews <[email protected]>
Signed-off-by: Rayyan Ansari <[email protected]>
---
.../qcom/qcom-msm8226-microsoft-common.dtsi | 332 ++++++++++++++++++
1 file changed, 332 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi
new file mode 100644
index 000000000000..b49ccf867964
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi
@@ -0,0 +1,332 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Common Board Device Tree for Microsoft MSM8x26-based Lumias
+ *
+ * Copyright (c) 2023, Jack Matthews <[email protected]>
+ * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
+ * Copyright (c) 2023, Dominik Kobinski <[email protected]>
+ * Copyright (c) 2023, Rayyan Ansari <[email protected]>
+ */
+
+#include "qcom-msm8226.dtsi"
+#include "qcom-pm8226.dtsi"
+#include <dt-bindings/input/input.h>
+
+/*
+ * Delete all generic (msm8226.dtsi) reserved
+ * memory mappings which are different on these devices.
+ */
+/delete-node/ &smem_region;
+
+/ {
+ aliases {
+ mmc0 = &sdhc_1; /* eMMC */
+ mmc1 = &sdhc_2; /* microSD */
+ display0 = &framebuffer0;
+ };
+
+ chosen {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ stdout-path = "display0";
+
+ framebuffer0: framebuffer@3200000 {
+ compatible = "simple-framebuffer";
+ reg = <0x3200000 0x800000>;
+ format = "a8r8g8b8";
+ width = <720>;
+ height = <1280>;
+ stride = <(720 * 4)>;
+
+ clocks = <&mmcc MDSS_AHB_CLK>,
+ <&mmcc MDSS_AXI_CLK>,
+ <&mmcc MDSS_BYTE0_CLK>,
+ <&mmcc MDSS_MDP_CLK>,
+ <&mmcc MDSS_PCLK0_CLK>,
+ <&mmcc MDSS_VSYNC_CLK>;
+ power-domains = <&mmcc MDSS_GDSC>;
+ };
+ };
+
+ gpio_keys: gpio-keys {
+ compatible = "gpio-keys";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&gpio_keys_active>;
+
+ label = "GPIO Buttons";
+
+ volume-up {
+ label = "Volume Up";
+ gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
+ };
+ };
+
+ /*
+ * This device being a WP platform has a different
+ * memory layout than other Android based devices.
+ * This smem memory region is directly copied from
+ * the original UEFI firmware.
+ */
+ reserved-memory {
+ ranges;
+
+ smem_region: smem@fa00000 {
+ reg = <0xfa00000 0x100000>;
+ no-map;
+ };
+
+ display_reserved: framebuffer@3200000 {
+ reg = <0x3200000 0x800000>;
+ no-map;
+ };
+ };
+};
+
+&blsp1_i2c5 {
+ status = "okay";
+
+ touchscreen@4b {
+ compatible = "syna,rmi4-i2c";
+ reg = <0x4b>;
+
+ interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
+ vdd-supply = <&pm8226_l15>;
+ vio-supply = <&pm8226_l6>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&touchscreen_on>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rmi4-f01@1 {
+ reg = <0x01>;
+ syna,nosleep-mode = <1>;
+ };
+
+ rmi4-f11@11 {
+ reg = <0x11>;
+ syna,sensor-type = <1>;
+ };
+ };
+};
+
+&blsp1_uart3 {
+ status = "okay";
+};
+
+&pm8226_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+ status = "okay";
+};
+
+&pm8226_vib {
+ status = "okay";
+};
+
+&rpm_requests {
+ pm8226-regulators {
+ compatible = "qcom,rpm-pm8226-regulators";
+
+ /* These values were taken from the original firmware DSDT */
+ pm8226_s1: s1 {
+ regulator-min-microvolt = <1050000>;
+ regulator-max-microvolt = <1050000>;
+ };
+
+ pm8226_s3: s3 {
+ regulator-min-microvolt = <1300000>;
+ regulator-max-microvolt = <1300000>;
+ };
+
+ pm8226_s4: s4 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <2100000>;
+ };
+
+ pm8226_s5: s5 {
+ regulator-min-microvolt = <1150000>;
+ regulator-max-microvolt = <1150000>;
+ };
+
+ pm8226_l3: l3 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <1150000>;
+ };
+
+ pm8226_l4: l4 {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+
+ pm8226_l5: l5 {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+
+ pm8226_l6: l6 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8226_l7: l7 {
+ regulator-min-microvolt = <1850000>;
+ regulator-max-microvolt = <1850000>;
+ };
+
+ pm8226_l8: l8 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ pm8226_l9: l9 {
+ regulator-min-microvolt = <2050000>;
+ regulator-max-microvolt = <2050000>;
+ };
+
+ pm8226_l10: l10 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8226_l12: l12 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8226_l14: l14 {
+ regulator-min-microvolt = <2750000>;
+ regulator-max-microvolt = <2750000>;
+ };
+
+ pm8226_l15: l15 {
+ regulator-min-microvolt = <2850000>;
+ regulator-max-microvolt = <2850000>;
+ };
+
+ pm8226_l16: l16 {
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8226_l17: l17 {
+ regulator-min-microvolt = <2950000>;
+ regulator-max-microvolt = <2950000>;
+ regulator-system-load = <200000>;
+ regulator-allow-set-load;
+ };
+
+ pm8226_l18: l18 {
+ regulator-min-microvolt = <2950000>;
+ regulator-max-microvolt = <2950000>;
+ regulator-system-load = <200000>;
+ regulator-allow-set-load;
+ };
+
+ pm8226_l19: l19 {
+ regulator-min-microvolt = <2850000>;
+ regulator-max-microvolt = <2850000>;
+ };
+
+ pm8226_l20: l20 {
+ regulator-min-microvolt = <3075000>;
+ regulator-max-microvolt = <3075000>;
+ };
+
+ pm8226_l21: l21 {
+ regulator-min-microvolt = <1850000>;
+ regulator-max-microvolt = <2950000>;
+ };
+
+ pm8226_l22: l22 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8226_l23: l23 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8226_l24: l24 {
+ regulator-min-microvolt = <1300000>;
+ regulator-max-microvolt = <1300000>;
+ };
+
+ pm8226_l25: l25 {
+ regulator-min-microvolt = <1775000>;
+ regulator-max-microvolt = <2075000>;
+ };
+
+ pm8226_l27: l27 {
+ regulator-min-microvolt = <2050000>;
+ regulator-max-microvolt = <2050000>;
+ };
+
+ pm8226_l28: l28 {
+ regulator-min-microvolt = <2000000>;
+ regulator-max-microvolt = <3000000>;
+ };
+ };
+};
+
+&sdhc_1 {
+ vmmc-supply = <&pm8226_l17>;
+ vqmmc-supply = <&pm8226_l6>;
+
+ status = "okay";
+};
+
+&sdhc_2 {
+ vmmc-supply = <&pm8226_l18>;
+ vqmmc-supply = <&pm8226_l21>;
+
+ status = "okay";
+};
+
+&usb {
+ extcon = <&smbb>;
+ dr_mode = "peripheral";
+
+ status = "okay";
+};
+
+&usb_hs_phy {
+ extcon = <&smbb>;
+ v1p8-supply = <&pm8226_l10>;
+ v3p3-supply = <&pm8226_l20>;
+};
+
+&tlmm {
+ gpio_keys_active: gpio-keys-active {
+ pins = "gpio106", "gpio107", "gpio108";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
+ touchscreen_on: touchscreen-on {
+ irq {
+ pins = "gpio17";
+ function = "gpio";
+
+ drive-strength = <8>;
+ bias-pull-up;
+ input-enable;
+ };
+
+ reset {
+ pins = "gpio16";
+ function = "gpio";
+
+ drive-strength = <8>;
+ bias-disable;
+ output-high;
+ };
+ };
+};
--
2.41.0


2023-08-11 23:02:27

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH 6/7] ARM: dts: qcom: add device tree for Nokia Lumia 735

Add an initial device tree for the Nokia Lumia 735, codenamed
"superman-lte".

Co-authored-by: Dominik Kobinski <[email protected]>
Co-authored-by: Ivaylo Ivanov <[email protected]>
Co-authored-by: Jack Matthews <[email protected]>
Signed-off-by: Dominik Kobinski <[email protected]>
Signed-off-by: Ivaylo Ivanov <[email protected]>
Signed-off-by: Jack Matthews <[email protected]>
Signed-off-by: Rayyan Ansari <[email protected]>
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-msm8926-microsoft-superman-lte.dts | 52 +++++++++++++++++++
2 files changed, 53 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts

diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index 487e0a5987ce..7982620ec9f9 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8916-samsung-e7.dtb \
qcom-msm8916-samsung-grandmax.dtb \
qcom-msm8916-samsung-serranove.dtb \
+ qcom-msm8926-microsoft-superman-lte.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
new file mode 100644
index 000000000000..9e165eddeca7
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023, Jack Matthews <[email protected]>
+ * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
+ * Copyright (c) 2023, Dominik Kobinski <[email protected]>
+ * Copyright (c) 2023, Rayyan Ansari <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-microsoft-common.dtsi"
+
+/ {
+ model = "Nokia Lumia 735";
+ compatible = "microsoft,superman-lte", "qcom,msm8926";
+ chassis-type = "handset";
+};
+
+&blsp1_i2c3 {
+ status = "okay";
+
+ touchscreen@4b {
+ compatible = "syna,rmi4-i2c";
+ reg = <0x4b>;
+
+ interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
+ vdd-supply = <&pm8226_l15>;
+ vio-supply = <&pm8226_l6>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&touchscreen_on>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rmi4-f01@1 {
+ reg = <0x01>;
+ syna,nosleep-mode = <1>;
+ };
+
+ rmi4-f11@11 {
+ reg = <0x11>;
+ syna,sensor-type = <1>;
+ };
+ };
+};
+
+&blsp1_i2c5 {
+ status = "disabled";
+
+ /delete-node/ touchscreen@4b;
+};
--
2.41.0


2023-08-11 23:15:47

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/7] ARM: dts: qcom: add common device tree for MSM8x26-based Lumia phones

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add a common device tree for Lumias based on the Qualcomm MSM8x26
> family of chipsets.
>
> Currently supports:
> - Framebuffer
> - Touchscreen
> - Keys
> - Regulators
> - MMC
> - USB
> - UART
>
> Co-authored-by: Dominik Kobinski <[email protected]>
> Co-authored-by: Ivaylo Ivanov <[email protected]>
> Co-authored-by: Jack Matthews <[email protected]>
> Signed-off-by: Dominik Kobinski <[email protected]>
> Signed-off-by: Ivaylo Ivanov <[email protected]>
> Signed-off-by: Jack Matthews <[email protected]>
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---
Would be really nice if you could squash it with patch 3 so that
this code is immediately compilable.

[...]

> + gpio_keys: gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&gpio_keys_active>;
property-n
property-names

[...]

> + reserved-memory {
> + ranges;
That's already there in soc dtsi

> +
> + smem_region: smem@fa00000 {
Swap the subnodes to keep the nodes ordered by unit address
> + reg = <0xfa00000 0x100000>;
> + no-map;
> + };
> +
> + display_reserved: framebuffer@3200000 {
> + reg = <0x3200000 0x800000>;
> + no-map;
> + };
> + };
> +};
> +
> +&blsp1_i2c5 {
> + status = "okay";
> +
> + touchscreen@4b {
> + compatible = "syna,rmi4-i2c";
> + reg = <0x4b>;
> +
> + interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
> + vdd-supply = <&pm8226_l15>;
> + vio-supply = <&pm8226_l6>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchscreen_on>;
ditto

> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rmi4-f01@1 {
> + reg = <0x01>;
> + syna,nosleep-mode = <1>;
> + };
> +
> + rmi4-f11@11 {
> + reg = <0x11>;
> + syna,sensor-type = <1>;
> + };
> + };
> +};
[...]

> +
> +&tlmm {
> + gpio_keys_active: gpio-keys-active {
Run `make CHECK_DTBS=1 qcom/msm8226-something-lumia` and fix the warnings
before Krzysztof gets angry :D

Konrad

2023-08-11 23:21:43

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/7] dt-bindings: arm: qcom: Document MSM8x26-based Lumia phones

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Document MSM8226 and MSM8926 Lumias.
>
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..ea4b1c530461 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -181,9 +181,18 @@ properties:
>
> - items:
> - enum:
> + - microsoft,dempsey
> + - microsoft,makepeace
> + - microsoft,moneypenny
> - samsung,s3ve3g
> - const: qcom,msm8226
>
> + - items:
> + - enum:
> + - microsoft,superman-lte
The '9' in msm8926 means "LTE".. is there a non-LTE superman?

Konrad

2023-08-11 23:21:46

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH 3/7] ARM: dts: qcom: add device tree for Nokia Lumia 630

Add an initial device tree for the Nokia Lumia 630, codenamed
"moneypenny".

Co-authored-by: Dominik Kobinski <[email protected]>
Co-authored-by: Ivaylo Ivanov <[email protected]>
Co-authored-by: Jack Matthews <[email protected]>
Signed-off-by: Dominik Kobinski <[email protected]>
Signed-off-by: Ivaylo Ivanov <[email protected]>
Signed-off-by: Jack Matthews <[email protected]>
Signed-off-by: Rayyan Ansari <[email protected]>
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-msm8226-microsoft-moneypenny.dts | 23 +++++++++++++++++++
2 files changed, 24 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts

diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index 3dfb1c8cefb8..b2569059ce8d 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-ipq4019-ap.dk07.1-c2.dtb \
qcom-ipq8064-ap148.dtb \
qcom-ipq8064-rb3011.dtb \
+ qcom-msm8226-microsoft-moneypenny.dtb \
qcom-msm8226-samsung-s3ve3g.dtb \
qcom-msm8660-surf.dtb \
qcom-msm8916-samsung-e5.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
new file mode 100644
index 000000000000..e13e018a6759
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023, Jack Matthews <[email protected]>
+ * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
+ * Copyright (c) 2023, Dominik Kobinski <[email protected]>
+ * Copyright (c) 2023, Rayyan Ansari <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-microsoft-common.dtsi"
+
+/ {
+ model = "Nokia Lumia 630";
+ compatible = "microsoft,moneypenny", "qcom,msm8226";
+ chassis-type = "handset";
+};
+
+&framebuffer0 {
+ width = <480>;
+ height = <854>;
+ stride = <(480 * 4)>;
+};
--
2.41.0


2023-08-11 23:22:06

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 4/7] ARM: dts: qcom: add device tree for Microsoft Lumia 640

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add an initial device tree for the Microsoft Lumia 640, codenamed
> "dempsey".
>
> Co-authored-by: Dominik Kobinski <[email protected]>
> Co-authored-by: Ivaylo Ivanov <[email protected]>
> Co-authored-by: Jack Matthews <[email protected]>
> Signed-off-by: Dominik Kobinski <[email protected]>
> Signed-off-by: Ivaylo Ivanov <[email protected]>
> Signed-off-by: Jack Matthews <[email protected]>
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2023-08-11 23:36:37

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 7/7] ARM: dts: qcom: add device tree for Nokia Lumia 830

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add an initial device tree for the Nokia Lumia 830, codenamed
> "tesla".
>
> Co-authored-by: Dominik Kobinski <[email protected]>
> Co-authored-by: Ivaylo Ivanov <[email protected]>
> Co-authored-by: Jack Matthews <[email protected]>
> Signed-off-by: Dominik Kobinski <[email protected]>
> Signed-off-by: Ivaylo Ivanov <[email protected]>
> Signed-off-by: Jack Matthews <[email protected]>
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---
> arch/arm/boot/dts/qcom/Makefile | 1 +
> .../dts/qcom/qcom-msm8926-microsoft-tesla.dts | 66 +++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
>
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 7982620ec9f9..a3d293e40820 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-msm8916-samsung-grandmax.dtb \
> qcom-msm8916-samsung-serranove.dtb \
> qcom-msm8926-microsoft-superman-lte.dtb \
> + qcom-msm8926-microsoft-tesla.dtb \
> qcom-msm8960-cdp.dtb \
> qcom-msm8960-samsung-expressatt.dtb \
> qcom-msm8974-lge-nexus5-hammerhead.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
> new file mode 100644
> index 000000000000..5a4f4687b895
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Jack Matthews <[email protected]>
> + * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
> + * Copyright (c) 2023, Dominik Kobinski <[email protected]>
> + * Copyright (c) 2023, Rayyan Ansari <[email protected]>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-microsoft-common.dtsi"
> +
> +/ {
> + model = "Nokia Lumia 830";
> + compatible = "microsoft,tesla", "qcom,msm8926";
> + chassis-type = "handset";
> +};
> +
> +&blsp1_i2c1 {
> + status = "okay";
> +
> + touchscreen@4b {
> + compatible = "syna,rmi4-i2c";
> + reg = <0x4b>;
> +
> + interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
> + vdd-supply = <&pm8226_l15>;
> + vio-supply = <&pm8226_l6>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchscreen_on>;
flip

Konrad
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rmi4-f01@1 {
> + reg = <0x01>;
> + syna,nosleep-mode = <1>;
> + };
> +
> + rmi4-f12@12 {
> + reg = <0x12>;
> + syna,sensor-type = <1>;
> + };
> + };
> +};
> +
> +&blsp1_i2c5 {
> + status = "disabled";
> +
> + /delete-node/ touchscreen@4b;
> +};
> +
> +&gpio_keys {
> + camera-snapshot {
> + label = "Camera Snapshot";
> + gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_CAMERA>;
> + };
> +
> + camera-focus {
> + label = "Camera Focus";
> + gpios = <&tlmm 108 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_CAMERA_FOCUS>;
> + };
> +};

2023-08-12 00:05:45

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 6/7] ARM: dts: qcom: add device tree for Nokia Lumia 735

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add an initial device tree for the Nokia Lumia 735, codenamed
> "superman-lte".
>
> Co-authored-by: Dominik Kobinski <[email protected]>
> Co-authored-by: Ivaylo Ivanov <[email protected]>
> Co-authored-by: Jack Matthews <[email protected]>
> Signed-off-by: Dominik Kobinski <[email protected]>
> Signed-off-by: Ivaylo Ivanov <[email protected]>
> Signed-off-by: Jack Matthews <[email protected]>
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---
> arch/arm/boot/dts/qcom/Makefile | 1 +
> .../qcom-msm8926-microsoft-superman-lte.dts | 52 +++++++++++++++++++
> 2 files changed, 53 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
>
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 487e0a5987ce..7982620ec9f9 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-msm8916-samsung-e7.dtb \
> qcom-msm8916-samsung-grandmax.dtb \
> qcom-msm8916-samsung-serranove.dtb \
> + qcom-msm8926-microsoft-superman-lte.dtb \
> qcom-msm8960-cdp.dtb \
> qcom-msm8960-samsung-expressatt.dtb \
> qcom-msm8974-lge-nexus5-hammerhead.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
> new file mode 100644
> index 000000000000..9e165eddeca7
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Jack Matthews <[email protected]>
> + * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
> + * Copyright (c) 2023, Dominik Kobinski <[email protected]>
> + * Copyright (c) 2023, Rayyan Ansari <[email protected]>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-microsoft-common.dtsi"
> +
> +/ {
> + model = "Nokia Lumia 735";
> + compatible = "microsoft,superman-lte", "qcom,msm8926";
Hm.. maybe "qcom,msm8926", "qcom,msm8226" so that we don't have to add
both to cpufreq_dt blacklist etc

> + chassis-type = "handset";
> +};
> +
> +&blsp1_i2c3 {
> + status = "okay";
> +
> + touchscreen@4b {
> + compatible = "syna,rmi4-i2c";
> + reg = <0x4b>;
> +
> + interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
> + vdd-supply = <&pm8226_l15>;
> + vio-supply = <&pm8226_l6>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchscreen_on>;
flip order

> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rmi4-f01@1 {
> + reg = <0x01>;
> + syna,nosleep-mode = <1>;
> + };
> +
> + rmi4-f11@11 {
> + reg = <0x11>;
> + syna,sensor-type = <1>;
> + };
> + };
> +};
> +
> +&blsp1_i2c5 {
> + status = "disabled";
sneaky microsoft

Konrad
> +
> + /delete-node/ touchscreen@4b;
> +};

2023-08-12 02:16:18

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 5/7] ARM: dts: qcom: add device tree for Microsoft Lumia 640 XL

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add an initial device tree for the Microsoft Lumia 640 XL, codenamed
> "makepeace".
>
> Co-authored-by: Dominik Kobinski <[email protected]>
> Co-authored-by: Ivaylo Ivanov <[email protected]>
> Co-authored-by: Jack Matthews <[email protected]>
> Signed-off-by: Dominik Kobinski <[email protected]>
> Signed-off-by: Ivaylo Ivanov <[email protected]>
> Signed-off-by: Jack Matthews <[email protected]>
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2023-08-12 02:57:01

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 3/7] ARM: dts: qcom: add device tree for Nokia Lumia 630

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add an initial device tree for the Nokia Lumia 630, codenamed
> "moneypenny".
>
> Co-authored-by: Dominik Kobinski <[email protected]>
> Co-authored-by: Ivaylo Ivanov <[email protected]>
> Co-authored-by: Jack Matthews <[email protected]>
> Signed-off-by: Dominik Kobinski <[email protected]>
> Signed-off-by: Ivaylo Ivanov <[email protected]>
> Signed-off-by: Jack Matthews <[email protected]>
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---
> arch/arm/boot/dts/qcom/Makefile | 1 +
> .../qcom-msm8226-microsoft-moneypenny.dts | 23 +++++++++++++++++++
> 2 files changed, 24 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
>
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 3dfb1c8cefb8..b2569059ce8d 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-ipq4019-ap.dk07.1-c2.dtb \
> qcom-ipq8064-ap148.dtb \
> qcom-ipq8064-rb3011.dtb \
> + qcom-msm8226-microsoft-moneypenny.dtb \
> qcom-msm8226-samsung-s3ve3g.dtb \
> qcom-msm8660-surf.dtb \
> qcom-msm8916-samsung-e5.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
> new file mode 100644
> index 000000000000..e13e018a6759
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Jack Matthews <[email protected]>
> + * Copyright (c) 2023, Ivaylo Ivanov <[email protected]>
> + * Copyright (c) 2023, Dominik Kobinski <[email protected]>
> + * Copyright (c) 2023, Rayyan Ansari <[email protected]>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-microsoft-common.dtsi"
> +
> +/ {
> + model = "Nokia Lumia 630";
> + compatible = "microsoft,moneypenny", "qcom,msm8226";
> + chassis-type = "handset";
> +};
> +
> +&framebuffer0 {
Guess s/framebuffer0/framebuffer would be in order

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2023-08-12 13:48:25

by Rayyan Ansari

[permalink] [raw]
Subject: Re: [PATCH 1/7] dt-bindings: arm: qcom: Document MSM8x26-based Lumia phones

On 11/08/2023 23:58, Konrad Dybcio wrote:
> On 11.08.2023 23:35, Rayyan Ansari wrote:
>> Document MSM8226 and MSM8926 Lumias.
>>
>> Signed-off-by: Rayyan Ansari <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 450f616774e0..ea4b1c530461 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -181,9 +181,18 @@ properties:
>>
>> - items:
>> - enum:
>> + - microsoft,dempsey
>> + - microsoft,makepeace
>> + - microsoft,moneypenny
>> - samsung,s3ve3g
>> - const: qcom,msm8226
>>
>> + - items:
>> + - enum:
>> + - microsoft,superman-lte
> The '9' in msm8926 means "LTE".. is there a non-LTE superman?
Yes, Lumia 730, based on MSM8226.
I didn't just make up this codename, the 735 is called superman_lte in
internal files.

>
> Konrad

--
Rayyan Ansari
https://ansari.sh


2023-08-13 13:12:40

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 1/7] dt-bindings: arm: qcom: Document MSM8x26-based Lumia phones

On Sat, Aug 12, 2023 at 12:50:28PM +0100, Rayyan Ansari wrote:
> On 11/08/2023 23:58, Konrad Dybcio wrote:
> > On 11.08.2023 23:35, Rayyan Ansari wrote:
> > > Document MSM8226 and MSM8926 Lumias.
> > >
> > > Signed-off-by: Rayyan Ansari <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > index 450f616774e0..ea4b1c530461 100644
> > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > @@ -181,9 +181,18 @@ properties:
> > > - items:
> > > - enum:
> > > + - microsoft,dempsey
> > > + - microsoft,makepeace
> > > + - microsoft,moneypenny
> > > - samsung,s3ve3g
> > > - const: qcom,msm8226
> > > + - items:
> > > + - enum:
> > > + - microsoft,superman-lte
> > The '9' in msm8926 means "LTE".. is there a non-LTE superman?
> Yes, Lumia 730, based on MSM8226.
> I didn't just make up this codename, the 735 is called superman_lte in
> internal files.

Acked-by: Conor Dooley <[email protected]>
Thanks,
Conor.


Attachments:
(No filename) (1.32 kB)
signature.asc (235.00 B)
Download all attachments