2023-08-14 12:28:40

by Marcus Folkesson

Subject: [PATCH v5 5/6] iio: adc: mcp3911: avoid ambiguity parameters in macros

Name macro parameters after what they represent instead of 'x'.

Suggested-by: Andy Shevchenko <[email protected]>
Signed-off-by: Marcus Folkesson <[email protected]>
---

Notes:
v5:
- New patch in this series

drivers/iio/adc/mcp3911.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c
index 1648eaa878eb..f1e02aa14e93 100644
--- a/drivers/iio/adc/mcp3911.c
+++ b/drivers/iio/adc/mcp3911.c
@@ -51,8 +51,8 @@
#define MCP3911_REG_GAINCAL_CH1 0x17
#define MCP3911_REG_VREFCAL 0x1a

-#define MCP3911_CHANNEL(x) (MCP3911_REG_CHANNEL0 + x * 3)
-#define MCP3911_OFFCAL(x) (MCP3911_REG_OFFCAL_CH0 + x * 6)
+#define MCP3911_CHANNEL(ch) (MCP3911_REG_CHANNEL0 + ch * 3)
+#define MCP3911_OFFCAL(ch) (MCP3911_REG_OFFCAL_CH0 + ch * 6)

/* Internal voltage reference in mV */
#define MCP3911_INT_VREF_MV 1200
--
2.41.0

2023-08-19 14:59:24

by Andy Shevchenko

Subject: Re: [PATCH v5 5/6] iio: adc: mcp3911: avoid ambiguity parameters in macros

On Mon, Aug 14, 2023 at 02:10:09PM +0200, Marcus Folkesson wrote:
> Name macro parameters after what they represent instead of 'x'.

Yes, but it's not my suggestion, what I was talking about is how macro
parameters being treated.

This change doesn't make the problem go away.

Per se, this one is good for its purposes.

> Suggested-by: Andy Shevchenko <[email protected]>

This shouldn't be here.

--
With Best Regards,
Andy Shevchenko