2023-08-15 06:40:22

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH] regulator: rtq2208: Switch back to use struct i2c_driver's .probe()

struct i2c_driver::probe_new is about to go away. Switch the driver to
use the probe callback with the same prototype.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
Hello,

would be great if this was the last regulator driver I had to switch.
It's the fifth driver I had to fixup as it was added with .probe_new
after 964e186547b2.

Thanks
Uwe

drivers/regulator/rtq2208-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/rtq2208-regulator.c b/drivers/regulator/rtq2208-regulator.c
index 2463aea4192c..2d54844c4226 100644
--- a/drivers/regulator/rtq2208-regulator.c
+++ b/drivers/regulator/rtq2208-regulator.c
@@ -574,7 +574,7 @@ static struct i2c_driver rtq2208_driver = {
.name = "rtq2208",
.of_match_table = rtq2208_device_tables,
},
- .probe_new = rtq2208_probe,
+ .probe = rtq2208_probe,
};
module_i2c_driver(rtq2208_driver);


base-commit: 85a11f55621a0c18b22b43ab4219450ac1d19386
--
2.40.1



2023-08-15 06:47:05

by Alina Yu

[permalink] [raw]
Subject: Re: [PATCH] regulator: rtq2208: Switch back to use struct i2c_driver's .probe()

On Mon, Aug 14, 2023 at 11:07:59PM +0200, Uwe Kleine-K?nig wrote:
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> ---
Hi,
Uwe

Thank you for your revising.

Reviewed-by: Alina Yu <[email protected]>

Best regards,
Alina

> drivers/regulator/rtq2208-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/rtq2208-regulator.c b/drivers/regulator/rtq2208-regulator.c
> index 2463aea4192c..2d54844c4226 100644
> --- a/drivers/regulator/rtq2208-regulator.c
> +++ b/drivers/regulator/rtq2208-regulator.c
> @@ -574,7 +574,7 @@ static struct i2c_driver rtq2208_driver = {
> .name = "rtq2208",
> .of_match_table = rtq2208_device_tables,
> },
> - .probe_new = rtq2208_probe,
> + .probe = rtq2208_probe,
> };
> module_i2c_driver(rtq2208_driver);
>
>
> base-commit: 85a11f55621a0c18b22b43ab4219450ac1d19386
> --
> 2.40.1
>

2023-08-15 14:43:40

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: rtq2208: Switch back to use struct i2c_driver's .probe()

On Mon, 14 Aug 2023 23:07:59 +0200, Uwe Kleine-König wrote:
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: rtq2208: Switch back to use struct i2c_driver's .probe()
commit: edff54ac96eb25f01d26cc68923a6dbbb5b2f440

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark