2023-08-09 12:08:52

by Artur Weber

Subject: [PATCH] backlight: lp855x: Drop ret variable in brightness change function

Fixes the following warning:

drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used
uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Signed-off-by: Artur Weber <[email protected]>
Fixes: 5145531be5fb ("backlight: lp855x: Catch errors when changing brightness")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
---
drivers/video/backlight/lp855x_bl.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index 61a7f45bfad8..da1f124db69c 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -241,19 +241,17 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
{
struct lp855x *lp = bl_get_data(bl);
int brightness = bl->props.brightness;
- int ret;

if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
brightness = 0;

if (lp->mode == PWM_BASED)
- ret = lp855x_pwm_ctrl(lp, brightness,
+ return lp855x_pwm_ctrl(lp, brightness,
bl->props.max_brightness);
else if (lp->mode == REGISTER_BASED)
- ret = lp855x_write_byte(lp, lp->cfg->reg_brightness,
+ return lp855x_write_byte(lp, lp->cfg->reg_brightness,
(u8)brightness);
-
- return ret;
+ return -EINVAL;
}

static const struct backlight_ops lp855x_bl_ops = {

base-commit: 21ef7b1e17d039053edaeaf41142423810572741
--
2.41.0

2023-08-09 17:22:56

by Daniel Thompson

Subject: Re: [PATCH] backlight: lp855x: Drop ret variable in brightness change function

On Wed, Aug 09, 2023 at 01:42:16PM +0200, Artur Weber wrote:
> Fixes the following warning:
>
> drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used
> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>
> Signed-off-by: Artur Weber <[email protected]>
> Fixes: 5145531be5fb ("backlight: lp855x: Catch errors when changing brightness")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Reviewed-by: Daniel Thompson <[email protected]>

2023-08-18 00:00:25

by Nathan Chancellor

Subject: Re: [PATCH] backlight: lp855x: Drop ret variable in brightness change function

On Wed, Aug 09, 2023 at 01:42:16PM +0200, Artur Weber wrote:
> Fixes the following warning:
>
> drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used
> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>
> Signed-off-by: Artur Weber <[email protected]>
> Fixes: 5145531be5fb ("backlight: lp855x: Catch errors when changing brightness")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> drivers/video/backlight/lp855x_bl.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index 61a7f45bfad8..da1f124db69c 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -241,19 +241,17 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
> int brightness = bl->props.brightness;
> - int ret;
>
> if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> brightness = 0;
>
> if (lp->mode == PWM_BASED)
> - ret = lp855x_pwm_ctrl(lp, brightness,
> + return lp855x_pwm_ctrl(lp, brightness,
> bl->props.max_brightness);
> else if (lp->mode == REGISTER_BASED)
> - ret = lp855x_write_byte(lp, lp->cfg->reg_brightness,
> + return lp855x_write_byte(lp, lp->cfg->reg_brightness,
> (u8)brightness);
> -
> - return ret;
> + return -EINVAL;
> }
>
> static const struct backlight_ops lp855x_bl_ops = {
>
> base-commit: 21ef7b1e17d039053edaeaf41142423810572741
> --
> 2.41.0
>

2023-08-18 17:01:57

by Lee Jones

Subject: Re: (subset) [PATCH] backlight: lp855x: Drop ret variable in brightness change function

On Wed, 09 Aug 2023 13:42:16 +0200, Artur Weber wrote:
> Fixes the following warning:
>
> drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used
> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>
>

Applied, thanks!

[1/1] backlight: lp855x: Drop ret variable in brightness change function
commit: dfd122fe8591d513b5e51313601217b67ae98d13

--
Lee Jones [李琼斯]