2023-08-02 09:41:55

by Li Zetao

Subject: [PATCH -next] mfd: ipaq-micro: Remove unused variable i in micro_rx_msg()

After the commit "92d82d76c84", the variable i is unused. Remove it
to silence the warning.

Reported-by: kernelci.org bot <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Li Zetao <[email protected]>
---
drivers/mfd/ipaq-micro.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index cddfd2e808f2..c964ea6539aa 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -78,8 +78,6 @@ EXPORT_SYMBOL(ipaq_micro_tx_msg);

static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data)
{
- int i;
-
dev_dbg(micro->dev, "RX msg: %02x, %d bytes\n", id, len);

spin_lock(&micro->lock);
--
2.34.1

2023-08-17 19:46:09

by Lee Jones

Subject: Re: [PATCH -next] mfd: ipaq-micro: Remove unused variable i in micro_rx_msg()

On Wed, 02 Aug 2023, Li Zetao wrote:

> After the commit "92d82d76c84", the variable i is unused. Remove it

Please use the format:

<short_sha> ("<subject>") when referencing commits.

> to silence the warning.

If you're referring to a warning, please paste it here.

> Reported-by: kernelci.org bot <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Li Zetao <[email protected]>
> ---
> drivers/mfd/ipaq-micro.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
> index cddfd2e808f2..c964ea6539aa 100644
> --- a/drivers/mfd/ipaq-micro.c
> +++ b/drivers/mfd/ipaq-micro.c
> @@ -78,8 +78,6 @@ EXPORT_SYMBOL(ipaq_micro_tx_msg);
>
> static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data)
> {
> - int i;
> -
> dev_dbg(micro->dev, "RX msg: %02x, %d bytes\n", id, len);
>
> spin_lock(&micro->lock);
> --
> 2.34.1
>

--
Lee Jones [李琼斯]

2023-08-18 18:06:34

by Li Zetao

Subject: [PATCH -next v2] mfd: ipaq-micro: Remove unused variable i in micro_rx_msg()

There is a warning reported by kernel test robot:

drivers/mfd/ipaq-micro.c:81:6: warning:
unused variable ‘i’ [-Wunused-variable]

Since the commit 92d82d76c842 ("mfd: ipaq-micro: Use %*ph for printing
hexdump of a small buffer"), the variable 'i' is unused. Remove it to
silence the warning.

Reported-by: kernelci.org bot <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Li Zetao <[email protected]>
---
v1 -> v2: Modify the format of the reference commit and add warning
information
v1: https://lore.kernel.org/all/[email protected]/

drivers/mfd/ipaq-micro.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index cddfd2e808f2..c964ea6539aa 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -78,8 +78,6 @@ EXPORT_SYMBOL(ipaq_micro_tx_msg);

static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data)
{
- int i;
-
dev_dbg(micro->dev, "RX msg: %02x, %d bytes\n", id, len);

spin_lock(&micro->lock);
--
2.34.1