2023-08-22 11:31:52

by Lee Jones

[permalink] [raw]
Subject: Re: (subset) [PATCH v6 06/10 RESEND] power: supply: rt5033_charger: Add cable detection and USB OTG supply

On Thu, 17 Aug 2023, Lee Jones wrote:

> On Mon, 15 May 2023 22:57:15 +0200, Jakob Hauser wrote:
> > Implement cable detection by extcon and handle the driver according to the
> > connector type.
> >
> > There are basically three types of action: "set_charging", "set_otg" and
> > "set_disconnect".
> >
> > A forth helper function to "unset_otg" was added because this is used in both
> > "set_charging" and "set_disconnect". In the first case it covers the rather
> > rare event that someone changes from OTG to charging without disconnect. In
> > the second case, when disconnecting, the values are set back to the ones from
> > initialization to return into a defined state.
> >
> > [...]
>
> Applied, thanks!
>
> [06/10] power: supply: rt5033_charger: Add cable detection and USB OTG supply
> commit: c1af6bcc8583b0a1083338cd26c2090d0bcb0810

Multiple fixes now follow this patch, so I am unapplying it.

Sebastian, would you mind collecting it up please?

--
Lee Jones [李琼斯]


2023-08-22 23:55:10

by Sebastian Reichel

[permalink] [raw]
Subject: Re: (subset) [PATCH v6 06/10 RESEND] power: supply: rt5033_charger: Add cable detection and USB OTG supply

Hi,

On Tue, Aug 22, 2023 at 08:07:37AM +0100, Lee Jones wrote:
> On Thu, 17 Aug 2023, Lee Jones wrote:
>
> > On Mon, 15 May 2023 22:57:15 +0200, Jakob Hauser wrote:
> > > Implement cable detection by extcon and handle the driver according to the
> > > connector type.
> > >
> > > There are basically three types of action: "set_charging", "set_otg" and
> > > "set_disconnect".
> > >
> > > A forth helper function to "unset_otg" was added because this is used in both
> > > "set_charging" and "set_disconnect". In the first case it covers the rather
> > > rare event that someone changes from OTG to charging without disconnect. In
> > > the second case, when disconnecting, the values are set back to the ones from
> > > initialization to return into a defined state.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [06/10] power: supply: rt5033_charger: Add cable detection and USB OTG supply
> > commit: c1af6bcc8583b0a1083338cd26c2090d0bcb0810
>
> Multiple fixes now follow this patch, so I am unapplying it.
>
> Sebastian, would you mind collecting it up please?

I'm leaving for a two week hiking trip (with basically no internet
access) in some hours. My planed return date is basically when Linus
is expected to tag 6.6-rc1, so I will not queue any more patches and
send my pull request early (within the next few hours).

I planned to catch up with the power-supply backlog last week during
Chaos Communication Camp, but it was too hot to do any sensible
review. Now I expect to process the power-supply backlog in the
week after the merge window.

Greetings and sorry for the inconvenience,

-- Sebastian


Attachments:
(No filename) (1.64 kB)
signature.asc (849.00 B)
Download all attachments