2023-08-24 15:40:12

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v3] leds: max5970: Add support for max5970

On Thu, 24 Aug 2023, Naresh Solanki wrote:

> From: Patrick Rudolph <[email protected]>
>
> The MAX5970 is hot swap controller and has 4 indication LED.
>
> Signed-off-by: Patrick Rudolph <[email protected]>
> Signed-off-by: Naresh Solanki <[email protected]>
> ---
> Changes in V3:
> - Drop array for ddata variable.
> Changes in V2:
> - Add of_node_put before return.
> - Code cleanup
> - Refactor code & remove max5970_setup_led function.

This is 3 revisions in the past 24hrs.

Please refrain from machine-gunning revisions out like this.

Send one and give reviewers a good few days to review.

> ---
> drivers/leds/Kconfig | 11 ++++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-max5970.c | 110 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 122 insertions(+)
> create mode 100644 drivers/leds/leds-max5970.c

--
Lee Jones [李琼斯]