2023-08-30 21:15:29

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH 0/7] drm/msm/dp: Simplify DPCD related code with helpers

This driver open-codes a few of the DPCD register reads when it can be
simplified by using the helpers instead. This series reworks the MSM DP
driver to use the DPCD helpers and removes some dead code along the way.
There's the potential for even more code reduction around the test
registers, but I haven't tried to do that yet.

Stephen Boyd (7):
drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps()
drm/msm/dp: Use drm_dp_read_sink_count() helper
drm/msm/dp: Remove dead code related to downstream cap info
drm/msm/dp: Remove aux_cfg_update_done and related code
drm/msm/dp: Simplify with drm_dp_{max_link_rate,max_lane_count}()
drm/msm/dp: Inline dp_link_parse_sink_count()
drm/msm/dp: Remove dp_display_is_ds_bridge()

Cc: Vinod Polimera <[email protected]>
Cc: Kuogee Hsieh <[email protected]>

drivers/gpu/drm/msm/dp/dp_display.c | 9 +--
drivers/gpu/drm/msm/dp/dp_link.c | 38 +---------
drivers/gpu/drm/msm/dp/dp_panel.c | 105 +++++-----------------------
drivers/gpu/drm/msm/dp/dp_panel.h | 10 +--
4 files changed, 22 insertions(+), 140 deletions(-)


base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
--
https://chromeos.dev



2023-10-08 14:02:07

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 0/7] drm/msm/dp: Simplify DPCD related code with helpers


On Tue, 29 Aug 2023 11:47:25 -0700, Stephen Boyd wrote:
> This driver open-codes a few of the DPCD register reads when it can be
> simplified by using the helpers instead. This series reworks the MSM DP
> driver to use the DPCD helpers and removes some dead code along the way.
> There's the potential for even more code reduction around the test
> registers, but I haven't tried to do that yet.
>
> Stephen Boyd (7):
> drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps()
> drm/msm/dp: Use drm_dp_read_sink_count() helper
> drm/msm/dp: Remove dead code related to downstream cap info
> drm/msm/dp: Remove aux_cfg_update_done and related code
> drm/msm/dp: Simplify with drm_dp_{max_link_rate,max_lane_count}()
> drm/msm/dp: Inline dp_link_parse_sink_count()
> drm/msm/dp: Remove dp_display_is_ds_bridge()
>
> [...]

Applied, thanks!

[1/7] drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps()
https://gitlab.freedesktop.org/lumag/msm/-/commit/f906b95755f7
[2/7] drm/msm/dp: Use drm_dp_read_sink_count() helper
https://gitlab.freedesktop.org/lumag/msm/-/commit/284a245d8bdc
[3/7] drm/msm/dp: Remove dead code related to downstream cap info
https://gitlab.freedesktop.org/lumag/msm/-/commit/8bddc2d12e9c
[4/7] drm/msm/dp: Remove aux_cfg_update_done and related code
https://gitlab.freedesktop.org/lumag/msm/-/commit/62ebb19fb32d
[5/7] drm/msm/dp: Simplify with drm_dp_{max_link_rate,max_lane_count}()
https://gitlab.freedesktop.org/lumag/msm/-/commit/a9905b469931
[6/7] drm/msm/dp: Inline dp_link_parse_sink_count()
https://gitlab.freedesktop.org/lumag/msm/-/commit/d89ce4cdb7a6
[7/7] drm/msm/dp: Remove dp_display_is_ds_bridge()
https://gitlab.freedesktop.org/lumag/msm/-/commit/b41c5ca70684

Best regards,
--
Dmitry Baryshkov <[email protected]>