2023-06-27 12:09:52

by Xinghui Li

Subject: [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch

From: Xinghui Li <[email protected]>

There is one inconsistent indenting warning:
"drivers/pci/controller/vmd.c:1058 vmd_resume()
warn: inconsistent indenting"

Fix it and remove the unnecessary if.

Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Signed-off-by: Xinghui Li <[email protected]>
---
drivers/pci/controller/vmd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 990630ec57c6..356bbeb548fe 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -1055,10 +1055,7 @@ static int vmd_resume(struct device *dev)
struct vmd_dev *vmd = pci_get_drvdata(pdev);
int err, i;

- if (vmd->irq_domain)
- vmd_set_msi_remapping(vmd, true);
- else
- vmd_set_msi_remapping(vmd, false);
+ vmd_set_msi_remapping(vmd, !!vmd->irq_domain);

for (i = 0; i < vmd->msix_count; i++) {
err = devm_request_irq(dev, vmd->irqs[i].virq,
--
2.39.3

2023-08-30 20:17:28

by Krzysztof Wilczyński

Subject: Re: [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch

Hello,

> There is one inconsistent indenting warning:
> "drivers/pci/controller/vmd.c:1058 vmd_resume()
> warn: inconsistent indenting"
>
> Fix it and remove the unnecessary if.

Applied to controller/vmd, thank you!

[1/1] PCI: vmd: Fix inconsistent indentation in vmd_resume()
https://git.kernel.org/pci/pci/c/1bae18a3eeee

Krzysztof