2023-09-04 18:16:41

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] dt-bindings: can: xilinx_can: Add ECC property 'xlnx,has-ecc'

On 01.09.2023 14:10:43, Srinivas Goud wrote:
> ECC feature added to Tx and Rx FIFOs for Xilinx AXI CAN Controller.
> Part of this feature configuration and counter registers added in
> IP for 1bit/2bit ECC errors.
>
> xlnx,has-ecc is optional property and added to Xilinx AXI CAN Controller
> node if ECC block enabled in the HW
>
> Signed-off-by: Srinivas Goud <[email protected]>
> ---
> Changes in v4:
> Fix binding check warning
> Update property description
>
> Changes in v3:
> Update commit description
>
> Changes in v2:
> None
>
> Documentation/devicetree/bindings/net/can/xilinx,can.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/xilinx,can.yaml b/Documentation/devicetree/bindings/net/can/xilinx,can.yaml
> index 64d57c3..50a2671 100644
> --- a/Documentation/devicetree/bindings/net/can/xilinx,can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/xilinx,can.yaml
> @@ -49,6 +49,10 @@ properties:
> resets:
> maxItems: 1
>
> + xlnx,has-ecc:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: CAN Tx and Rx fifo has ECC (AXI CAN)

Are there 2 FIFOs? If so I'd phrase it this way:
"CAN TX and RX FIFOs have ECC support (AXI CAN)" - or -
"CAN TX and RX FIFOs support ECC"

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |


Attachments:
(No filename) (1.57 kB)
signature.asc (499.00 B)
Download all attachments