2023-09-12 21:00:10

by Stephan Gerhold

[permalink] [raw]
Subject: [PATCH 0/4] cpufreq: Add basic cpufreq scaling for Qualcomm MSM8909

Add the necessary definitions to the qcom-cpufreq-nvmem driver to
support basic cpufreq scaling on the Qualcomm MSM8909 SoC. In practice
the necessary power domains vary depending on the actual PMIC the SoC
was combined with. With PM8909 the VDD_APC power domain is shared with
VDD_CX so the RPM firmware handles all voltage adjustments, while with
PM8916 and PM660 Linux is responsible to do adaptive voltage scaling
of a dedicated CPU regulator using CPR.

Signed-off-by: Stephan Gerhold <[email protected]>
---
Stephan Gerhold (4):
cpufreq: qcom-nvmem: Enable virtual power domain devices
cpufreq: dt: platdev: Add MSM8909 to blocklist
dt-bindings: cpufreq: qcom-nvmem: Document MSM8909
cpufreq: qcom-nvmem: Add MSM8909

.../bindings/cpufreq/qcom-cpufreq-nvmem.yaml | 1 +
drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
drivers/cpufreq/qcom-cpufreq-nvmem.c | 47 +++++++++++++++++++++-
3 files changed, 48 insertions(+), 1 deletion(-)
---
base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
change-id: 20230906-msm8909-cpufreq-dff238de9ff3

Best regards,
--
Stephan Gerhold <[email protected]>
Kernkonzept GmbH at Dresden, Germany, HRB 31129, CEO Dr.-Ing. Michael Hohmuth


2023-09-12 22:33:55

by Stephan Gerhold

[permalink] [raw]
Subject: [PATCH 3/4] dt-bindings: cpufreq: qcom-nvmem: Document MSM8909

Document that MSM8909 is used with qcom-cpufreq-nvmem for voltage
scaling and to restrict the maximum frequency based on the speedbin
encoded in the nvmem cells.

Signed-off-by: Stephan Gerhold <[email protected]>
---
Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
index 7e1bb992ce90..09315a1d8fc1 100644
--- a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
@@ -29,6 +29,7 @@ select:
- qcom,apq8096
- qcom,ipq8064
- qcom,ipq8074
+ - qcom,msm8909
- qcom,msm8939
- qcom,msm8960
- qcom,msm8974

--
2.39.2

2023-09-13 16:44:20

by Stephan Gerhold

[permalink] [raw]
Subject: [PATCH 2/4] cpufreq: dt: platdev: Add MSM8909 to blocklist

MSM8909 uses qcom-cpufreq-nvmem to attach power domains and to parse the
speedbin from NVMEM (for opp-supported-hw).

Signed-off-by: Stephan Gerhold <[email protected]>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index fb2875ce1fdd..984d2ad1a474 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -141,6 +141,7 @@ static const struct of_device_id blocklist[] __initconst = {
{ .compatible = "nvidia,tegra210", },
{ .compatible = "nvidia,tegra234", },

+ { .compatible = "qcom,msm8909", },
{ .compatible = "qcom,apq8096", },
{ .compatible = "qcom,msm8996", },
{ .compatible = "qcom,msm8998", },

--
2.39.2

2023-09-13 21:16:15

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/4] cpufreq: dt: platdev: Add MSM8909 to blocklist

On 12.09.2023 11:40, Stephan Gerhold wrote:
> MSM8909 uses qcom-cpufreq-nvmem to attach power domains and to parse the
> speedbin from NVMEM (for opp-supported-hw).
>
> Signed-off-by: Stephan Gerhold <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2023-09-28 11:00:25

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 2/4] cpufreq: dt: platdev: Add MSM8909 to blocklist

On 12-09-23, 11:40, Stephan Gerhold wrote:
> MSM8909 uses qcom-cpufreq-nvmem to attach power domains and to parse the
> speedbin from NVMEM (for opp-supported-hw).
>
> Signed-off-by: Stephan Gerhold <[email protected]>
> ---
> drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index fb2875ce1fdd..984d2ad1a474 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -141,6 +141,7 @@ static const struct of_device_id blocklist[] __initconst = {
> { .compatible = "nvidia,tegra210", },
> { .compatible = "nvidia,tegra234", },
>
> + { .compatible = "qcom,msm8909", },
> { .compatible = "qcom,apq8096", },

Alphabetical order would have been better.

Fixed and applied. Thanks.

--
viresh