2023-09-12 18:48:09

by Stephan Gerhold

Subject: [PATCH 3/4] spi: dt-bindings: qup: Document interconnects

When the SPI QUP controller is used together with a DMA engine it needs
to vote for the interconnect path to the DRAM. Otherwise it may be
unable to access the memory quickly enough.

Signed-off-by: Stephan Gerhold <[email protected]>
---
Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml
index 1e498a791406..88be13268962 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml
@@ -44,6 +44,9 @@ properties:
- const: tx
- const: rx

+ interconnects:
+ maxItems: 1
+
interrupts:
maxItems: 1

@@ -67,6 +70,7 @@ unevaluatedProperties: false
examples:
- |
#include <dt-bindings/clock/qcom,gcc-msm8996.h>
+ #include <dt-bindings/interconnect/qcom,msm8996.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/power/qcom-rpmpd.h>

@@ -84,6 +88,7 @@ examples:
dma-names = "tx", "rx";
power-domains = <&rpmpd MSM8996_VDDCX>;
operating-points-v2 = <&spi_opp_table>;
+ interconnects = <&pnoc MASTER_BLSP_1 &bimc SLAVE_EBI_CH0>;
#address-cells = <1>;
#size-cells = <0>;
};

--
2.39.2

2023-09-13 09:42:46

by Krzysztof Kozlowski

Subject: Re: [PATCH 3/4] spi: dt-bindings: qup: Document interconnects

On 12/09/2023 16:30, Stephan Gerhold wrote:
> When the SPI QUP controller is used together with a DMA engine it needs
> to vote for the interconnect path to the DRAM. Otherwise it may be
> unable to access the memory quickly enough.
>
> Signed-off-by: Stephan Gerhold <[email protected]>
> ---
> Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml | 5 +++++
> 1 file changed, 5 insertions(+)

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof