The original commit hasn't been updated according to
refactoring done in sdm845.dtsi.
Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
Suggested-by: Dmitry Baryshkov <[email protected]>
Reviewed-by: Douglas Anderson <[email protected]>
Signed-off-by: David Heidelberg <[email protected]>
---
v2:
- removed power-domains from apps_rsc
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 50934d4ab3bc..e0ee91225eec 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -144,15 +144,15 @@ panel_in_edp: endpoint {
};
&psci {
- /delete-node/ cpu0;
- /delete-node/ cpu1;
- /delete-node/ cpu2;
- /delete-node/ cpu3;
- /delete-node/ cpu4;
- /delete-node/ cpu5;
- /delete-node/ cpu6;
- /delete-node/ cpu7;
- /delete-node/ cpu-cluster0;
+ /delete-node/ power-domain-cpu0;
+ /delete-node/ power-domain-cpu1;
+ /delete-node/ power-domain-cpu2;
+ /delete-node/ power-domain-cpu3;
+ /delete-node/ power-domain-cpu4;
+ /delete-node/ power-domain-cpu5;
+ /delete-node/ power-domain-cpu6;
+ /delete-node/ power-domain-cpu7;
+ /delete-node/ power-domain-cluster;
};
&cpus {
@@ -338,6 +338,8 @@ flash@0 {
&apps_rsc {
+ /delete-property/ power-domains;
+
regulators-0 {
compatible = "qcom,pm8998-rpmh-regulators";
qcom,pmic-id = "a";
--
2.40.1
On 23-09-12 12:42:03, David Heidelberg wrote:
> The original commit hasn't been updated according to
> refactoring done in sdm845.dtsi.
>
> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
> Suggested-by: Dmitry Baryshkov <[email protected]>
> Reviewed-by: Douglas Anderson <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
Reviewed-by: Abel Vesa <[email protected]>
> ---
> v2:
> - removed power-domains from apps_rsc
>
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> index 50934d4ab3bc..e0ee91225eec 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> @@ -144,15 +144,15 @@ panel_in_edp: endpoint {
> };
>
> &psci {
> - /delete-node/ cpu0;
> - /delete-node/ cpu1;
> - /delete-node/ cpu2;
> - /delete-node/ cpu3;
> - /delete-node/ cpu4;
> - /delete-node/ cpu5;
> - /delete-node/ cpu6;
> - /delete-node/ cpu7;
> - /delete-node/ cpu-cluster0;
> + /delete-node/ power-domain-cpu0;
> + /delete-node/ power-domain-cpu1;
> + /delete-node/ power-domain-cpu2;
> + /delete-node/ power-domain-cpu3;
> + /delete-node/ power-domain-cpu4;
> + /delete-node/ power-domain-cpu5;
> + /delete-node/ power-domain-cpu6;
> + /delete-node/ power-domain-cpu7;
> + /delete-node/ power-domain-cluster;
> };
>
> &cpus {
> @@ -338,6 +338,8 @@ flash@0 {
>
>
> &apps_rsc {
> + /delete-property/ power-domains;
> +
> regulators-0 {
> compatible = "qcom,pm8998-rpmh-regulators";
> qcom,pmic-id = "a";
> --
> 2.40.1
>
Cheza firmware doesn't allow controlling LMh from the operating system.
Fixes: 36c6581214c4 ("arm64: dts: qcom: sdm845: Add support for LMh node")
Suggested-by: Dmitry Baryshkov <[email protected]>
Signed-off-by: David Heidelberg <[email protected]>
---
v2:
- moved power-domains removal from this patch to previous one, since
it's not related to LMh support
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index e0ee91225eec..e51bf02fbfe3 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -143,6 +143,10 @@ panel_in_edp: endpoint {
};
};
+&cpufreq_hw {
+ /delete-property/ interrupts-extended; /* reference to lmh_cluster[01] */
+};
+
&psci {
/delete-node/ power-domain-cpu0;
/delete-node/ power-domain-cpu1;
@@ -275,6 +279,14 @@ &BIG_CPU_SLEEP_1
&CLUSTER_SLEEP_0>;
};
+&lmh_cluster0 {
+ status = "disabled";
+};
+
+&lmh_cluster1 {
+ status = "disabled";
+};
+
/*
* Reserved memory changes
*
--
2.40.1
Quoting David Heidelberg (2023-09-12 00:12:03)
> The original commit hasn't been updated according to
> refactoring done in sdm845.dtsi.
>
> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
> Suggested-by: Dmitry Baryshkov <[email protected]>
> Reviewed-by: Douglas Anderson <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
Quoting David Heidelberg (2023-09-12 00:12:04)
> Cheza firmware doesn't allow controlling LMh from the operating system.
>
> Fixes: 36c6581214c4 ("arm64: dts: qcom: sdm845: Add support for LMh node")
> Suggested-by: Dmitry Baryshkov <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
Hi,
On Tue, Sep 12, 2023 at 12:14 AM David Heidelberg <[email protected]> wrote:
>
> Cheza firmware doesn't allow controlling LMh from the operating system.
>
> Fixes: 36c6581214c4 ("arm64: dts: qcom: sdm845: Add support for LMh node")
> Suggested-by: Dmitry Baryshkov <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> v2:
> - moved power-domains removal from this patch to previous one, since
> it's not related to LMh support
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
I haven't used a cheza in years, but this seems reasonable to me.
Reviewed-by: Douglas Anderson <[email protected]>
On Tue, 12 Sep 2023 12:42:03 +0530, David Heidelberg wrote:
> The original commit hasn't been updated according to
> refactoring done in sdm845.dtsi.
>
>
Applied, thanks!
[1/2] arm64: dts: qcom: sdm845: Fix PSCI power domain names
commit: a5f01673d3946e424091e6b8ff274716f9c21454
[2/2] arm64: dts: qcom: sdm845: cheza doesn't support LMh node
commit: 197ae69d1caedb3203e0b189a39efb820675fd5c
Best regards,
--
Bjorn Andersson <[email protected]>