2023-09-12 07:49:44

by Macpaul Lin

[permalink] [raw]
Subject: [PATCH v3 1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible

Fix compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'.

Signed-off-by: Macpaul Lin <[email protected]>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

change for v2:
- rebase this patch to follow the v5 patch set of mt8395.
- depends on https://lore.kernel.org/lkml/[email protected]/T/
- Fix description as a single board.

changes for v3:
- rebase this patch to follow the v6 patch set of mt8395.
- depends on https://lore.kernel.org/lkml/[email protected]/T/
- drop "Fixes:" tag in commit message.
- drop platform description update for mt8365-evk (Genio 350-EVK).

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 2e8ad49c3479..bab4fa0e8199 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -245,7 +245,7 @@ properties:
- mediatek,mt8183-pumpkin
- const: mediatek,mt8183
- items:
- - enum:
+ - const:
- mediatek,mt8365-evk
- const: mediatek,mt8365
- description: MediaTek Genio 1200 Boards (Genio 1200 EVK)
--
2.18.0


2023-09-12 08:16:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible

On 12/09/2023 09:23, Macpaul Lin wrote:
> Fix compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'.

What is there to fix? There is no bug... please describe why you are
doing changes.

>
> Signed-off-by: Macpaul Lin <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> change for v2:
> - rebase this patch to follow the v5 patch set of mt8395.
> - depends on https://lore.kernel.org/lkml/[email protected]/T/
> - Fix description as a single board.
>
> changes for v3:
> - rebase this patch to follow the v6 patch set of mt8395.
> - depends on https://lore.kernel.org/lkml/[email protected]/T/
> - drop "Fixes:" tag in commit message.
> - drop platform description update for mt8365-evk (Genio 350-EVK).
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 2e8ad49c3479..bab4fa0e8199 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -245,7 +245,7 @@ properties:
> - mediatek,mt8183-pumpkin
> - const: mediatek,mt8183
> - items:
> - - enum:
> + - const:

Obviously this was not tested... Please test before sending.

Best regards,
Krzysztof

2023-09-12 11:42:47

by Macpaul Lin

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible

On 9/12/23 16:08, Krzysztof Kozlowski wrote:
>
>
> External email : Please do not click links or open attachments until you
> have verified the sender or the content.
>
> On 12/09/2023 09:23, Macpaul Lin wrote:
>> Fix compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'.
>
> What is there to fix? There is no bug... please describe why you are
> doing changes.
>
>>
>> Signed-off-by: Macpaul Lin <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/mediatek.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> change for v2:
>> - rebase this patch to follow the v5 patch set of mt8395.
>> - depends on https://lore.kernel.org/lkml/[email protected]/T/
>> - Fix description as a single board.
>>
>> changes for v3:
>> - rebase this patch to follow the v6 patch set of mt8395.
>> - depends on https://lore.kernel.org/lkml/[email protected]/T/
>> - drop "Fixes:" tag in commit message.
>> - drop platform description update for mt8365-evk (Genio 350-EVK).
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> index 2e8ad49c3479..bab4fa0e8199 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> @@ -245,7 +245,7 @@ properties:
>> - mediatek,mt8183-pumpkin
>> - const: mediatek,mt8183
>> - items:
>> - - enum:
>> + - const:
>
> Obviously this was not tested... Please test before sending.
>
> Best regards,
> Krzysztof
>

I'm sorry, will be fixed in v4 with dtbs_check test.

Thanks
Macpaul Lin

2023-09-12 15:08:13

by Macpaul Lin

[permalink] [raw]
Subject: [PATCH v3 2/2] arm64: dts: mediatek: rename mt8365-evk to mt8365-genio-350-evk

Rename mt8365-evk to mt8365-genio-350-evk for following the
naming rules for MediaTek boards.

Signed-off-by: Macpaul Lin <[email protected]>
---
arch/arm64/boot/dts/mediatek/Makefile | 2 +-
.../dts/mediatek/{mt8365-evk.dts => mt8365-genio-350-evk.dts} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename arch/arm64/boot/dts/mediatek/{mt8365-evk.dts => mt8365-genio-350-evk.dts} (100%)

Changes for v1:
Changes for v2:
- None.
Changes for v3:
- New patch added into this patch set v3.
- depends on https://lore.kernel.org/lkml/[email protected]/T/

diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 10e640c6ae08..b5d529d66393 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -52,6 +52,6 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-cherry-tomato-r2.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-cherry-tomato-r3.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-demo.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-evb.dtb
-dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-genio-350-evk.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-genio-1200-evk.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-genio-350-evk.dts
similarity index 100%
rename from arch/arm64/boot/dts/mediatek/mt8365-evk.dts
rename to arch/arm64/boot/dts/mediatek/mt8365-genio-350-evk.dts
--
2.18.0