2023-09-12 17:34:36

by Gavrilov Ilia

Subject: [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()

The 'state->im' value will always be non-zero after
the 'while' statement, so the check can be removed.

Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Signed-off-by: Gavrilov Ilia <[email protected]>
---
Repost according to https://lore.kernel.org/all/[email protected]/
net/ipv4/igmp.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 418e5fb58fd3..76c3ea75b8dd 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -2944,8 +2944,6 @@ static struct ip_sf_list *igmp_mcf_get_next(struct seq_file *seq, struct ip_sf_l
continue;
state->im = rcu_dereference(state->idev->mc_list);
}
- if (!state->im)
- break;
spin_lock_bh(&state->im->lock);
psf = state->im->sources;
}
--
2.39.2

2023-09-14 15:45:05

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <[email protected]>:

On Tue, 12 Sep 2023 08:42:34 +0000 you wrote:
> The 'state->im' value will always be non-zero after
> the 'while' statement, so the check can be removed.
>
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
>
> Signed-off-by: Gavrilov Ilia <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()
https://git.kernel.org/netdev/net-next/c/a613ed1afd96

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html