2023-09-12 19:07:05

by Arnd Bergmann

Subject: [PATCH] net: ti: icssg-prueth: add PTP dependency

From: Arnd Bergmann <[email protected]>

The driver can now use PTP if enabled but fails to link built-in
if PTP is a loadable module:

aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'

Add the usual dependency to avoid this.

Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/net/ethernet/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 7f3e2e96c6e20..26ddc26fc7b8d 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH

config TI_ICSS_IEP
tristate "TI PRU ICSS IEP driver"
+ depends on PTP_1588_CLOCK_OPTIONAL
depends on TI_PRUSS
default TI_PRUSS
help
--
2.39.2

2023-09-13 08:19:34

by Jiri Pirko

Subject: Re: [PATCH] net: ti: icssg-prueth: add PTP dependency

Tue, Sep 12, 2023 at 08:54:51PM CEST, [email protected] wrote:
>From: Arnd Bergmann <[email protected]>
>
>The driver can now use PTP if enabled but fails to link built-in
>if PTP is a loadable module:
>
>aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
>icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
>
>Add the usual dependency to avoid this.
>
>Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
>Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Jiri Pirko <[email protected]>

2023-09-13 12:15:45

by MD Danish Anwar

Subject: [PATCH] net: ti: icssg-prueth: add PTP dependency

On 13/09/23 00:24, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The driver can now use PTP if enabled but fails to link built-in
> if PTP is a loadable module:
>
> aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
> icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
>
> Add the usual dependency to avoid this.
>
> Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
> Signed-off-by: Arnd Bergmann <[email protected]>
Reviewed-by: MD Danish Anwar <[email protected]>

> ---
> drivers/net/ethernet/ti/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 7f3e2e96c6e20..26ddc26fc7b8d 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH
>
> config TI_ICSS_IEP
> tristate "TI PRU ICSS IEP driver"
> + depends on PTP_1588_CLOCK_OPTIONAL
> depends on TI_PRUSS
> default TI_PRUSS
> help

--
Thanks and Regards,
Danish

2023-09-15 10:16:43

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: ti: icssg-prueth: add PTP dependency

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

On Tue, 12 Sep 2023 20:54:51 +0200 you wrote:
> From: Arnd Bergmann <[email protected]>
>
> The driver can now use PTP if enabled but fails to link built-in
> if PTP is a loadable module:
>
> aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
> icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
>
> [...]

Here is the summary with links:
- net: ti: icssg-prueth: add PTP dependency
https://git.kernel.org/netdev/net/c/a8f367f7e131

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html