We currently provide the physical address of the DMA region
rather than the output of dma_map_resource() which is obviously wrong.
Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
Cc: [email protected]
Reviewed-by: Manivannan Sadhasivam <[email protected]>
Signed-off-by: Bibek Kumar Patro <[email protected]>
---
v5: Incorporated suggestions from Miquel/Mani
- Added tag to automatically include this patch in stable tree.
v4: Incorporated suggestion from Miquel
- Modified title and commit description.
https://lore.kernel.org/all/[email protected]/
v3: Incorporated comments from Miquel
- Modified the commit message and title as per suggestions.
https://lore.kernel.org/all/[email protected]/
v2: Incorporated comments from Pavan/Mani.
https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/
drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
index 64499c1b3603..b079605c84d3 100644
--- a/drivers/mtd/nand/raw/qcom_nandc.c
+++ b/drivers/mtd/nand/raw/qcom_nandc.c
@@ -3444,7 +3444,7 @@ static int qcom_nandc_probe(struct platform_device *pdev)
err_aon_clk:
clk_disable_unprepare(nandc->core_clk);
err_core_clk:
- dma_unmap_resource(dev, res->start, resource_size(res),
+ dma_unmap_resource(dev, nandc->base_dma, resource_size(res),
DMA_BIDIRECTIONAL, 0);
return ret;
}
--
2.17.1
On Wed, 2023-09-13 at 07:07:02 UTC, Bibek Kumar Patro wrote:
> We currently provide the physical address of the DMA region
> rather than the output of dma_map_resource() which is obviously wrong.
>
> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
> Cc: [email protected]
> Reviewed-by: Manivannan Sadhasivam <[email protected]>
> Signed-off-by: Bibek Kumar Patro <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel