In order to convert Loongson1 MAC platform devices to the devicetree
nodes, Loongson1 MAC arch-code should be moved to the driver dir.
Add dt-binding document and update MAINTAINERS file accordingly.
In other words, this patchset is a preparation for converting
Loongson1 platform devices to devicetree.
Changelog
V4 -> V5: Replace stmmac_probe_config_dt() with devm_stmmac_probe_config_dt()
Replace stmmac_pltfr_probe() with devm_stmmac_pltfr_probe()
Squash patch 4 into patch 2 and 3
V3 -> V4: Add Acked-by tag from Krzysztof Kozlowski
Add "|" to description part
Amend "phy-mode" property
Drop ls1x_dwmac_syscon definition and its instances
Drop three redundant fields from the ls1x_dwmac structure
Drop the ls1x_dwmac_init() method.
Update the dt-binding document entry of Loongson1 Ethernet
Some minor improvements
V2 -> V3: Split the DT-schema file into loongson,ls1b-gmac.yaml
and loongson,ls1c-emac.yaml (suggested by Serge Semin)
Change the compatibles to loongson,ls1b-gmac and loongson,ls1c-emac
Rename loongson,dwmac-syscon to loongson,ls1-syscon
Amend the title
Add description
Add Reviewed-by tag from Krzysztof Kozlowski
Change compatibles back to loongson,ls1b-syscon
and loongson,ls1c-syscon
Determine the device ID by physical
base address(suggested by Serge Semin)
Use regmap instead of regmap fields
Use syscon_regmap_lookup_by_phandle()
Some minor fixes
Update the entries of MAINTAINERS
V1 -> V2: Leave the Ethernet platform data for now
Make the syscon compatibles more specific
Fix "clock-names" and "interrupt-names" property
Rename the syscon property to "loongson,dwmac-syscon"
Drop "phy-handle" and "phy-mode" requirement
Revert adding loongson,ls1b-dwmac/loongson,ls1c-dwmac
to snps,dwmac.yaml
Fix the build errors due to CONFIG_OF being unset
Change struct reg_field definitions to const
Rename the syscon property to "loongson,dwmac-syscon"
Add MII PHY mode for LS1C
Improve the commit message
Keguang Zhang (3):
dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon
dt-bindings: net: Add Loongson-1 Ethernet Controller
net: stmmac: Add glue layer for Loongson-1 SoC
.../devicetree/bindings/mfd/syscon.yaml | 2 +
.../bindings/net/loongson,ls1b-gmac.yaml | 114 ++++++++++
.../bindings/net/loongson,ls1c-emac.yaml | 113 ++++++++++
MAINTAINERS | 2 +
drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 +
drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
.../ethernet/stmicro/stmmac/dwmac-loongson1.c | 209 ++++++++++++++++++
7 files changed, 452 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1b-gmac.yaml
create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1c-emac.yaml
create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c
base-commit: 98897dc735cf6635f0966f76eb0108354168fb15
--
2.39.2
Add Loongson LS1B and LS1C compatibles for system controller.
Signed-off-by: Keguang Zhang <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
V4 -> V5: None
V3 -> V4: Add Acked-by tag from Krzysztof Kozlowski
V2 -> V3: Change compatibles back to loongson,ls1b-syscon
and loongson,ls1c-syscon
V1 -> V2: Make the syscon compatibles more specific
Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 8103154bbb52..c77d7b155a4c 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -49,6 +49,8 @@ properties:
- hisilicon,peri-subctrl
- hpe,gxp-sysreg
- intel,lgm-syscon
+ - loongson,ls1b-syscon
+ - loongson,ls1c-syscon
- marvell,armada-3700-usb2-host-misc
- mediatek,mt8135-pctl-a-syscfg
- mediatek,mt8135-pctl-b-syscfg
--
2.39.2
On Fri, Sep 15, 2023 at 03:23:44PM +0200, Philippe Mathieu-Daud? wrote:
> On 15/9/23 11:55, Serge Semin wrote:
> > Hi Keguang
> >
> > On Thu, Sep 14, 2023 at 07:44:32PM +0800, Keguang Zhang wrote:
> > > In order to convert Loongson1 MAC platform devices to the devicetree
> > > nodes, Loongson1 MAC arch-code should be moved to the driver dir.
> > > Add dt-binding document and update MAINTAINERS file accordingly.
> > > In other words, this patchset is a preparation for converting
> > > Loongson1 platform devices to devicetree.
> >
> > No more comments from my side. Thank you for the patches and
> > especially for the patience in the review process.
> >
> > For the entire series:
> > Reviewed-by: Serge Semin <[email protected]>
> >
> > * I'll also send individual Rb tags to each patch so b4 would be able
> > * to take it into account.
>
> Maintainers using b4 should use the '-t' option, then you don't need
> to do that:
>
> -t, --apply-cover-trailers
>
> By default, b4 will not apply any code review trailers sent to
> the cover letter (but will let you know when it finds those).
> This lets you automatically apply these trailers to all commits
> in the series. This will become the default in a future version
> of b4.
>
> https://b4.docs.kernel.org/en/latest/maintainer/am-shazam.html#common-flags
Oh, got it. Can't believe I didn't figure out to take a closer look at
the help-page. Thanks for pointing it out to me.
-Serge(y)
Hi Keguang
On Thu, Sep 14, 2023 at 07:44:32PM +0800, Keguang Zhang wrote:
> In order to convert Loongson1 MAC platform devices to the devicetree
> nodes, Loongson1 MAC arch-code should be moved to the driver dir.
> Add dt-binding document and update MAINTAINERS file accordingly.
>
> In other words, this patchset is a preparation for converting
> Loongson1 platform devices to devicetree.
No more comments from my side. Thank you for the patches and
especially for the patience in the review process.
For the entire series:
Reviewed-by: Serge Semin <[email protected]>
* I'll also send individual Rb tags to each patch so b4 would be able
* to take it into account.
-Serge(y)
>
> Changelog
> V4 -> V5: Replace stmmac_probe_config_dt() with devm_stmmac_probe_config_dt()
> Replace stmmac_pltfr_probe() with devm_stmmac_pltfr_probe()
> Squash patch 4 into patch 2 and 3
> V3 -> V4: Add Acked-by tag from Krzysztof Kozlowski
> Add "|" to description part
> Amend "phy-mode" property
> Drop ls1x_dwmac_syscon definition and its instances
> Drop three redundant fields from the ls1x_dwmac structure
> Drop the ls1x_dwmac_init() method.
> Update the dt-binding document entry of Loongson1 Ethernet
> Some minor improvements
> V2 -> V3: Split the DT-schema file into loongson,ls1b-gmac.yaml
> and loongson,ls1c-emac.yaml (suggested by Serge Semin)
> Change the compatibles to loongson,ls1b-gmac and loongson,ls1c-emac
> Rename loongson,dwmac-syscon to loongson,ls1-syscon
> Amend the title
> Add description
> Add Reviewed-by tag from Krzysztof Kozlowski
> Change compatibles back to loongson,ls1b-syscon
> and loongson,ls1c-syscon
> Determine the device ID by physical
> base address(suggested by Serge Semin)
> Use regmap instead of regmap fields
> Use syscon_regmap_lookup_by_phandle()
> Some minor fixes
> Update the entries of MAINTAINERS
> V1 -> V2: Leave the Ethernet platform data for now
> Make the syscon compatibles more specific
> Fix "clock-names" and "interrupt-names" property
> Rename the syscon property to "loongson,dwmac-syscon"
> Drop "phy-handle" and "phy-mode" requirement
> Revert adding loongson,ls1b-dwmac/loongson,ls1c-dwmac
> to snps,dwmac.yaml
> Fix the build errors due to CONFIG_OF being unset
> Change struct reg_field definitions to const
> Rename the syscon property to "loongson,dwmac-syscon"
> Add MII PHY mode for LS1C
> Improve the commit message
>
> Keguang Zhang (3):
> dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon
> dt-bindings: net: Add Loongson-1 Ethernet Controller
> net: stmmac: Add glue layer for Loongson-1 SoC
>
> .../devicetree/bindings/mfd/syscon.yaml | 2 +
> .../bindings/net/loongson,ls1b-gmac.yaml | 114 ++++++++++
> .../bindings/net/loongson,ls1c-emac.yaml | 113 ++++++++++
> MAINTAINERS | 2 +
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 +
> drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
> .../ethernet/stmicro/stmmac/dwmac-loongson1.c | 209 ++++++++++++++++++
> 7 files changed, 452 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1b-gmac.yaml
> create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1c-emac.yaml
> create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c
>
>
> base-commit: 98897dc735cf6635f0966f76eb0108354168fb15
> --
> 2.39.2
>
>
On Thu, Sep 14, 2023 at 07:44:33PM +0800, Keguang Zhang wrote:
> Add Loongson LS1B and LS1C compatibles for system controller.
>
> Signed-off-by: Keguang Zhang <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Serge Semin <[email protected]>
-Serge(y)
> ---
> V4 -> V5: None
> V3 -> V4: Add Acked-by tag from Krzysztof Kozlowski
> V2 -> V3: Change compatibles back to loongson,ls1b-syscon
> and loongson,ls1c-syscon
> V1 -> V2: Make the syscon compatibles more specific
>
> Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 8103154bbb52..c77d7b155a4c 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -49,6 +49,8 @@ properties:
> - hisilicon,peri-subctrl
> - hpe,gxp-sysreg
> - intel,lgm-syscon
> + - loongson,ls1b-syscon
> + - loongson,ls1c-syscon
> - marvell,armada-3700-usb2-host-misc
> - mediatek,mt8135-pctl-a-syscfg
> - mediatek,mt8135-pctl-b-syscfg
> --
> 2.39.2
>
>
On 15/9/23 11:55, Serge Semin wrote:
> Hi Keguang
>
> On Thu, Sep 14, 2023 at 07:44:32PM +0800, Keguang Zhang wrote:
>> In order to convert Loongson1 MAC platform devices to the devicetree
>> nodes, Loongson1 MAC arch-code should be moved to the driver dir.
>> Add dt-binding document and update MAINTAINERS file accordingly.
>>
>> In other words, this patchset is a preparation for converting
>> Loongson1 platform devices to devicetree.
>
> No more comments from my side. Thank you for the patches and
> especially for the patience in the review process.
>
> For the entire series:
> Reviewed-by: Serge Semin <[email protected]>
>
> * I'll also send individual Rb tags to each patch so b4 would be able
> * to take it into account.
Maintainers using b4 should use the '-t' option, then you don't need
to do that:
-t, --apply-cover-trailers
By default, b4 will not apply any code review trailers sent to
the cover letter (but will let you know when it finds those).
This lets you automatically apply these trailers to all commits
in the series. This will become the default in a future version
of b4.
https://b4.docs.kernel.org/en/latest/maintainer/am-shazam.html#common-flags
Hello:
This series was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:
On Thu, 14 Sep 2023 19:44:32 +0800 you wrote:
> In order to convert Loongson1 MAC platform devices to the devicetree
> nodes, Loongson1 MAC arch-code should be moved to the driver dir.
> Add dt-binding document and update MAINTAINERS file accordingly.
>
> In other words, this patchset is a preparation for converting
> Loongson1 platform devices to devicetree.
>
> [...]
Here is the summary with links:
- [v5,1/3] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon
https://git.kernel.org/netdev/net-next/c/7e10088bc4e4
- [v5,2/3] dt-bindings: net: Add Loongson-1 Ethernet Controller
https://git.kernel.org/netdev/net-next/c/2af21077fa9f
- [v5,3/3] net: stmmac: Add glue layer for Loongson-1 SoC
https://git.kernel.org/netdev/net-next/c/d301c66b35b4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
On Thu, 14 Sep 2023 19:44:33 +0800, Keguang Zhang wrote:
> Add Loongson LS1B and LS1C compatibles for system controller.
>
>
Applied, thanks!
[1/3] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon
commit: d6e3854f720f13bad60c086d3cb4ea2c1958214a
--
Lee Jones [李琼斯]