2023-09-15 06:38:55

by Yang Li

Subject: [PATCH -next] perf kwork top: Simplify bool conversion

./tools/perf/util/bpf_kwork_top.c:120:53-58: WARNING: conversion to bool not needed here

Signed-off-by: Yang Li <[email protected]>
---
tools/perf/util/bpf_kwork_top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/bpf_kwork_top.c b/tools/perf/util/bpf_kwork_top.c
index 1a607b94f44d..035e02272790 100644
--- a/tools/perf/util/bpf_kwork_top.c
+++ b/tools/perf/util/bpf_kwork_top.c
@@ -117,7 +117,7 @@ kwork_class_bpf_supported_list[KWORK_CLASS_MAX] = {

static bool valid_kwork_class_type(enum kwork_class_type type)
{
- return type >= 0 && type < KWORK_CLASS_MAX ? true : false;
+ return type >= 0 && type < KWORK_CLASS_MAX;
}

static int setup_filters(struct perf_kwork *kwork)
--
2.20.1.7.g153144c

2023-09-21 18:56:45

by Namhyung Kim

Subject: Re: [PATCH -next] perf kwork top: Simplify bool conversion

On Thu, Sep 14, 2023 at 11:38 PM Yang Li <[email protected]> wrote:
>
> ./tools/perf/util/bpf_kwork_top.c:120:53-58: WARNING: conversion to bool not needed here
>
> Signed-off-by: Yang Li <[email protected]>

Applied to perf-tools-next, thanks!