2023-09-15 11:14:37

by Neha Malcom Francis

Subject: [PATCH v2 2/2] soc: ti k3-socinfo: Fix typo

Fix typo in driver that comments out wrong bit.

Signed-off-by: Neha Malcom Francis <[email protected]>
---
drivers/soc/ti/k3-socinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c
index 6de1e3531af9..417f3f33cd01 100644
--- a/drivers/soc/ti/k3-socinfo.c
+++ b/drivers/soc/ti/k3-socinfo.c
@@ -20,7 +20,7 @@
* 31-28 VARIANT Device variant
* 27-12 PARTNO Part number
* 11-1 MFG Indicates TI as manufacturer (0x17)
- * 1 Always 1
+ * 0 Always 1
*/
#define CTRLMMR_WKUP_JTAGID_VARIANT_SHIFT (28)
#define CTRLMMR_WKUP_JTAGID_VARIANT_MASK GENMASK(31, 28)
--
2.34.1

2023-09-15 17:21:06

by Nishanth Menon

Subject: Re: [PATCH v2 2/2] soc: ti k3-socinfo: Fix typo

On 12:16-20230915, Neha Malcom Francis wrote:
> Fix typo in driver that comments out wrong bit.
>
> Signed-off-by: Neha Malcom Francis <[email protected]>
> ---
> drivers/soc/ti/k3-socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c
> index 6de1e3531af9..417f3f33cd01 100644
> --- a/drivers/soc/ti/k3-socinfo.c
> +++ b/drivers/soc/ti/k3-socinfo.c
> @@ -20,7 +20,7 @@
> * 31-28 VARIANT Device variant
> * 27-12 PARTNO Part number
> * 11-1 MFG Indicates TI as manufacturer (0x17)
> - * 1 Always 1
> + * 0 Always 1
> */
> #define CTRLMMR_WKUP_JTAGID_VARIANT_SHIFT (28)
> #define CTRLMMR_WKUP_JTAGID_VARIANT_MASK GENMASK(31, 28)
> --
> 2.34.1
>

Always do basic cleanup early in your series. reverse the order of the
patches.

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D