2023-09-15 08:30:15

by Chen Wang

[permalink] [raw]
Subject: [PATCH 03/12] dt-bindings: riscv: add sophgo sg2042 bindings

Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
Milk-V Pioneer board [2].

[1]: https://en.sophgo.com/product/introduce/sg2042.html
[2]: https://milkv.io/pioneer

Signed-off-by: Wang Chen <[email protected]>
Signed-off-by: Xiaoguang Xing <[email protected]>
---
.../devicetree/bindings/riscv/sophgo.yaml | 28 +++++++++++++++++++
MAINTAINERS | 6 ++++
2 files changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml

diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
new file mode 100644
index 000000000000..82468ae915db
--- /dev/null
+++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sophgo SoC-based boards
+
+maintainers:
+ - Chao Wei <[email protected]>
+ - Xiaoguang Xing <[email protected]>
+
+description:
+ Sophgo SoC-based boards
+
+properties:
+ $nodename:
+ const: '/'
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - milkv,pioneer
+ - const: sophgo,sg2042
+
+additionalProperties: true
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 90f13281d297..0e0d477dab38 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20063,6 +20063,12 @@ F: drivers/char/sonypi.c
F: drivers/platform/x86/sony-laptop.c
F: include/linux/sony-laptop.h

+SOPHGO DEVICETREES
+M: Xiaoguang Xing <[email protected]>
+M: Chao Wei <[email protected]>
+S: Maintained
+F: Documentation/devicetree/bindings/riscv/sophgo.yaml
+
SOUND
M: Jaroslav Kysela <[email protected]>
M: Takashi Iwai <[email protected]>
--
2.25.1


2023-09-15 09:31:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 03/12] dt-bindings: riscv: add sophgo sg2042 bindings

On 15/09/2023 09:22, Wang Chen wrote:
> Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> Milk-V Pioneer board [2].
>
> [1]: https://en.sophgo.com/product/introduce/sg2042.html
> [2]: https://milkv.io/pioneer
>
> Signed-off-by: Wang Chen <[email protected]>
> Signed-off-by: Xiaoguang Xing <[email protected]>

Fix your email threading :/



Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-09-15 14:40:03

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 03/12] dt-bindings: riscv: add sophgo sg2042 bindings

On Fri, Sep 15, 2023 at 03:11:04PM +0100, Conor Dooley wrote:
> On Fri, Sep 15, 2023 at 03:22:42PM +0800, Wang Chen wrote:
> > Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> > Milk-V Pioneer board [2].
> >
> > [1]: https://en.sophgo.com/product/introduce/sg2042.html
> > [2]: https://milkv.io/pioneer
> >
> > Signed-off-by: Wang Chen <[email protected]>
> > Signed-off-by: Xiaoguang Xing <[email protected]>
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 90f13281d297..0e0d477dab38 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20063,6 +20063,12 @@ F: drivers/char/sonypi.c
> > F: drivers/platform/x86/sony-laptop.c
> > F: include/linux/sony-laptop.h
> >
> > +SOPHGO DEVICETREES
> > +M: Xiaoguang Xing <[email protected]>
> > +M: Chao Wei <[email protected]>
> > +S: Maintained
> > +F: Documentation/devicetree/bindings/riscv/sophgo.yaml
>
> I would like to see an Ack from those you are volunteering here.

I'm going to assume that you also add coverage here for the dts files
later in the series, but since the thing isnt't threaded it is hard to
check easily. If not, then a MAINTAINERS entry covering them should be
added, featuring a person that is going to monitor the lists, apply
patches and send PRs to the soc maintainers.

As a last resort, I can do that, but I don't have this hardware and
would rather someone that specifically cares for this hardware does it.

Thanks,
Conor.


Attachments:
(No filename) (1.46 kB)
signature.asc (235.00 B)
Download all attachments

2023-09-15 18:13:28

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 03/12] dt-bindings: riscv: add sophgo sg2042 bindings

On Fri, Sep 15, 2023 at 03:22:42PM +0800, Wang Chen wrote:
> Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> Milk-V Pioneer board [2].
>
> [1]: https://en.sophgo.com/product/introduce/sg2042.html
> [2]: https://milkv.io/pioneer
>
> Signed-off-by: Wang Chen <[email protected]>
> Signed-off-by: Xiaoguang Xing <[email protected]>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 90f13281d297..0e0d477dab38 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20063,6 +20063,12 @@ F: drivers/char/sonypi.c
> F: drivers/platform/x86/sony-laptop.c
> F: include/linux/sony-laptop.h
>
> +SOPHGO DEVICETREES
> +M: Xiaoguang Xing <[email protected]>
> +M: Chao Wei <[email protected]>
> +S: Maintained
> +F: Documentation/devicetree/bindings/riscv/sophgo.yaml

I would like to see an Ack from those you are volunteering here.

Thanks,
Conor.


Attachments:
(No filename) (911.00 B)
signature.asc (235.00 B)
Download all attachments