2023-09-15 14:14:38

by Chen Wang

Subject: [PATCH 11/12] riscv: dts: sophgo: Add sophgo,sg2024-uart compatibles

Add compatible for uart.

Signed-off-by: Emil Renner Berthing <[email protected]>
Signed-off-by: Wang Chen <[email protected]>
---
arch/riscv/boot/dts/sophgo/sg2042.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
index 5c4b82f13207..87f7667bbe63 100644
--- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
+++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
@@ -492,7 +492,7 @@ &cpu63_intc 0xffffffff &cpu63_intc 9
};

uart0: serial@7040000000 {
- compatible = "snps,dw-apb-uart";
+ compatible = "sophgo,sg2042-uart", "snps,dw-apb-uart";
reg = <0x00000070 0x40000000 0x00000000 0x00001000>;
interrupt-parent = <&intc>;
interrupts = <SOC_PERIPHERAL_IRQ(112) IRQ_TYPE_LEVEL_HIGH>;
--
2.25.1

2023-09-15 14:57:48

by Krzysztof Kozlowski

Subject: Re: [PATCH 11/12] riscv: dts: sophgo: Add sophgo,sg2024-uart compatibles

On 15/09/2023 09:26, Wang Chen wrote:
> Add compatible for uart.
>
> Signed-off-by: Emil Renner Berthing <[email protected]>
> Signed-off-by: Wang Chen <[email protected]>
> ---
> arch/riscv/boot/dts/sophgo/sg2042.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> index 5c4b82f13207..87f7667bbe63 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> @@ -492,7 +492,7 @@ &cpu63_intc 0xffffffff &cpu63_intc 9
> };
>
> uart0: serial@7040000000 {
> - compatible = "snps,dw-apb-uart";
> + compatible = "sophgo,sg2042-uart", "snps,dw-apb-uart";

No, you just added this file. Do not add buggy code which is fixed in
next patch.

Best regards,
Krzysztof