2023-09-15 18:38:25

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][next] ASoC: cs42l43: make const array controls static

Don't populate the const array controls on the stack, instead make it
static.

Signed-off-by: Colin Ian King <[email protected]>
---
sound/soc/codecs/cs42l43.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c
index 1a95c370fc4c..4e3bc15f1b25 100644
--- a/sound/soc/codecs/cs42l43.c
+++ b/sound/soc/codecs/cs42l43.c
@@ -162,7 +162,7 @@ CS42L43_IRQ_COMPLETE(load_detect)
static irqreturn_t cs42l43_mic_shutter(int irq, void *data)
{
struct cs42l43_codec *priv = data;
- const char * const controls[] = {
+ static const char * const controls[] = {
"Decimator 1 Switch",
"Decimator 2 Switch",
"Decimator 3 Switch",
--
2.39.2


2023-09-15 19:46:34

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH][next] ASoC: cs42l43: make const array controls static

On Fri, Sep 15, 2023 at 10:26:39AM +0100, Colin Ian King wrote:
> Don't populate the const array controls on the stack, instead make it
> static.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles

2023-09-16 01:27:52

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH][next] ASoC: cs42l43: make const array controls static

On Fri, 15 Sep 2023 10:26:39 +0100, Colin Ian King wrote:
> Don't populate the const array controls on the stack, instead make it
> static.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs42l43: make const array controls static
commit: 9dc098e3d7297ec895436a799f5faf27d430674c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark