2023-09-15 13:04:42

by Rohan G Thomas

Subject: [PATCH net-next v6 1/2] dt-bindings: net: snps,dwmac: Tx coe unsupported

Add dt-bindings for coe-unsupported property per tx queue.

Signed-off-by: Rohan G Thomas <[email protected]>
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index ddf9522a5dc2..365e6cb73484 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -394,6 +394,9 @@ properties:
When a PFC frame is received with priorities matching the bitmask,
the queue is blocked from transmitting for the pause time specified
in the PFC frame.
+ snps,coe-unsupported:
+ type: boolean
+ description: TX checksum offload is unsupported by the TX queue.
allOf:
- if:
required:
--
2.25.1

2023-09-15 15:46:12

by Rob Herring (Arm)

Subject: Re: [PATCH net-next v6 1/2] dt-bindings: net: snps,dwmac: Tx coe unsupported

On Fri, Sep 15, 2023 at 05:54:16PM +0800, Rohan G Thomas wrote:
> Add dt-bindings for coe-unsupported property per tx queue.

Why? (What every commit msg should answer)

>
> Signed-off-by: Rohan G Thomas <[email protected]>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index ddf9522a5dc2..365e6cb73484 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -394,6 +394,9 @@ properties:
> When a PFC frame is received with priorities matching the bitmask,
> the queue is blocked from transmitting for the pause time specified
> in the PFC frame.

blank line needed

> + snps,coe-unsupported:
> + type: boolean
> + description: TX checksum offload is unsupported by the TX queue.

And here.

> allOf:
> - if:
> required:
> --
> 2.25.1
>

2023-09-16 17:25:40

by Rohan G Thomas

Subject: Re: [linux-drivers-review] [PATCH net-next v2 1/3] net: stmmac: xgmac: EST interrupts handling

From: Rohan G Thomas <[email protected]>

Thanks for the review comments.
Will address this in the next version.

On Fri, Sep 15, 2023 at 05:54:16PM +0800, Rohan G Thomas wrote:
>> Add dt-bindings for coe-unsupported property per tx queue.
>
>Why? (What every commit msg should answer)
>
>>
>> Signed-off-by: Rohan G Thomas <[email protected]>
>> ---
>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> index ddf9522a5dc2..365e6cb73484 100644
>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> @@ -394,6 +394,9 @@ properties:
>> When a PFC frame is received with priorities matching the bitmask,
>> the queue is blocked from transmitting for the pause time specified
>> in the PFC frame.
>
>blank line needed
>
>> + snps,coe-unsupported:
>> + type: boolean
>> + description: TX checksum offload is unsupported by the TX queue.
>
>And here.
>
>> allOf:
>> - if:
>> required:
>> --
>> 2.25.1
>>