2023-09-18 01:41:28

by Benjamin Bara

[permalink] [raw]
Subject: [PATCH 04/13] clk: print debug message if parent change is ignored

From: Benjamin Bara <[email protected]>

Print a debug message if the determination of the best clock rate
suggests a re-config of the parent (which means the actual driver
considers doing so), but the clock is not configured with
CLK_SET_PARENT_RATE.

This should give a good hint for clock config improvement potential.

Signed-off-by: Benjamin Bara <[email protected]>
---
drivers/clk/clk.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 3e222802b712..4954d31899ce 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2241,9 +2241,14 @@ static struct clk_core *clk_calc_new_rates(struct clk_core *core,
}
}

- if ((core->flags & CLK_SET_RATE_PARENT) && parent &&
- best_parent_rate != parent->rate)
- top = clk_calc_new_rates(parent, best_parent_rate);
+ if (parent && best_parent_rate != parent->rate) {
+ if (core->flags & CLK_SET_RATE_PARENT)
+ top = clk_calc_new_rates(parent, best_parent_rate);
+ else
+ pr_debug("%s: ignore parent %s re-config from %lu to %lu\n",
+ core->name, parent->name, parent->rate,
+ best_parent_rate);
+ }

out:
clk_calc_subtree(core, new_rate, parent, p_index);

--
2.34.1