2023-09-15 15:06:03

by Bartosz Golaszewski

Subject: [PATCH v3 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find()

From: Bartosz Golaszewski <[email protected]>

We're porting all users of gpiochip_find() to using gpio_device_find().
Update the ACPI GPIO code.

Signed-off-by: Bartosz Golaszewski <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
---
drivers/gpio/gpiolib-acpi.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 17a86bdd9609..2378e1e7e8b9 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -143,7 +143,7 @@ static int acpi_gpiochip_find(struct gpio_chip *gc, void *data)
*/
static struct gpio_desc *acpi_get_gpiod(char *path, unsigned int pin)
{
- struct gpio_chip *chip;
+ struct gpio_device *gdev __free(gpio_device_put) = NULL;
acpi_handle handle;
acpi_status status;

@@ -151,11 +151,15 @@ static struct gpio_desc *acpi_get_gpiod(char *path, unsigned int pin)
if (ACPI_FAILURE(status))
return ERR_PTR(-ENODEV);

- chip = gpiochip_find(handle, acpi_gpiochip_find);
- if (!chip)
+ gdev = gpio_device_find(handle, acpi_gpiochip_find);
+ if (!gdev)
return ERR_PTR(-EPROBE_DEFER);

- return gpiochip_get_desc(chip, pin);
+ /*
+ * FIXME: keep track of the reference to the GPIO device somehow
+ * instead of putting it here.
+ */
+ return gpio_device_get_desc(gdev, pin);
}

/**
--
2.39.2

2023-09-18 12:22:35

by Mika Westerberg

Subject: Re: [PATCH v3 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find()

On Fri, Sep 15, 2023 at 05:03:24PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> We're porting all users of gpiochip_find() to using gpio_device_find().
> Update the ACPI GPIO code.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> Reviewed-by: Linus Walleij <[email protected]>

Reviewed-by: Mika Westerberg <[email protected]>