Remove the repeated word "the" in comments.
Signed-off-by: Charles Han <[email protected]>
---
Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
index 1625d1131093..a0678101a7d0 100644
--- a/Documentation/filesystems/xfs-online-fsck-design.rst
+++ b/Documentation/filesystems/xfs-online-fsck-design.rst
@@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
2. The second transaction contains a physical update to the free space btrees
of AG 3 to release the former BMBT block and a second physical update to the
free space btrees of AG 7 to release the unmapped file space.
- Observe that the the physical updates are resequenced in the correct order
+ Observe that the physical updates are resequenced in the correct order
when possible.
Attached to the transaction is a an extent free done (EFD) log item.
The EFD contains a pointer to the EFI logged in transaction #1 so that log
--
2.31.1
On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote:
> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
> index 1625d1131093..a0678101a7d0 100644
> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
> 2. The second transaction contains a physical update to the free space btrees
> of AG 3 to release the former BMBT block and a second physical update to the
> free space btrees of AG 7 to release the unmapped file space.
> - Observe that the the physical updates are resequenced in the correct order
> + Observe that the physical updates are resequenced in the correct order
> when possible.
> Attached to the transaction is a an extent free done (EFD) log item.
> The EFD contains a pointer to the EFI logged in transaction #1 so that log
I don't see any code comments in that doc. The patch title should have been
"Documentation: xfs: Remove duplicate 'the' in transaction sequence process".
Thanks.
--
An old man doll... just what I always wanted! - Clara
[cc [email protected]]
Hi Charles,
For future reference, can you CC the XFS list on XFS documentation
changes please? That's much preferable to sending patches to random
developers and hoping they notice it....
On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote:
> Remove the repeated word "the" in comments.
>
> Signed-off-by: Charles Han <[email protected]>
> ---
> Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
> index 1625d1131093..a0678101a7d0 100644
> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
> 2. The second transaction contains a physical update to the free space btrees
> of AG 3 to release the former BMBT block and a second physical update to the
> free space btrees of AG 7 to release the unmapped file space.
> - Observe that the the physical updates are resequenced in the correct order
> + Observe that the physical updates are resequenced in the correct order
Change looks fine, though.
Reviewed: Dave Chinner <[email protected]>
--
Dave Chinner
[email protected]
On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote:
> [cc [email protected]]
>
> Hi Charles,
>
> For future reference, can you CC the XFS list on XFS documentation
> changes please? That's much preferable to sending patches to random
> developers and hoping they notice it....
>
> On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote:
> > Remove the repeated word "the" in comments.
> >
> > Signed-off-by: Charles Han <[email protected]>
> > ---
> > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
To be fair, this new file isn't listed in MAINTAINERS, so
scripts/get_maintainer.pl doesn't know about it. May I
suggest the attached patch?
On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote:
> [cc [email protected]]
>
> Hi Charles,
>
> For future reference, can you CC the XFS list on XFS documentation
> changes please? That's much preferable to sending patches to random
> developers and hoping they notice it....
>
> On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote:
> > Remove the repeated word "the" in comments.
> >
> > Signed-off-by: Charles Han <[email protected]>
Yup.
Reviewed-by: Darrick J. Wong <[email protected]>
--D
> > ---
> > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
> > index 1625d1131093..a0678101a7d0 100644
> > --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> > +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> > @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
> > 2. The second transaction contains a physical update to the free space btrees
> > of AG 3 to release the former BMBT block and a second physical update to the
> > free space btrees of AG 7 to release the unmapped file space.
> > - Observe that the the physical updates are resequenced in the correct order
> > + Observe that the physical updates are resequenced in the correct order
>
> Change looks fine, though.
>
> Reviewed: Dave Chinner <[email protected]>
>
> --
> Dave Chinner
> [email protected]
>
On Tue, Sep 19, 2023 at 10:15:21PM +0100, Matthew Wilcox wrote:
> On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote:
> > [cc [email protected]]
> >
> > Hi Charles,
> >
> > For future reference, can you CC the XFS list on XFS documentation
> > changes please? That's much preferable to sending patches to random
> > developers and hoping they notice it....
> >
> > On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote:
> > > Remove the repeated word "the" in comments.
> > >
> > > Signed-off-by: Charles Han <[email protected]>
> > > ---
> > > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
>
> To be fair, this new file isn't listed in MAINTAINERS, so
> scripts/get_maintainer.pl doesn't know about it. May I
> suggest the attached patch?
> From e0eb2f0d1425e6a5dae23c983eb793afa5d040c1 Mon Sep 17 00:00:00 2001
> From: "Matthew Wilcox (Oracle)" <[email protected]>
> Date: Tue, 19 Sep 2023 17:12:45 -0400
> Subject: [PATCH] XFS: Update MAINTAINERS to catch all XFS documentation
>
> Assumes that all XFS documentation will be prefixed with xfs-, which
> seems like a good policy anyway.
>
> Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
LGTM,
Reviewed-by: Darrick J. Wong <[email protected]>
--D
> ---
> MAINTAINERS | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bf0f54c24f81..3554195022ee 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23640,8 +23640,7 @@ T: git git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
> P: Documentation/filesystems/xfs-maintainer-entry-profile.rst
> F: Documentation/ABI/testing/sysfs-fs-xfs
> F: Documentation/admin-guide/xfs.rst
> -F: Documentation/filesystems/xfs-delayed-logging-design.rst
> -F: Documentation/filesystems/xfs-self-describing-metadata.rst
> +F: Documentation/filesystems/xfs-*
> F: fs/xfs/
> F: include/uapi/linux/dqblk_xfs.h
> F: include/uapi/linux/fsmap.h
> --
> 2.40.1
>
On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote:
> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
> index 1625d1131093..a0678101a7d0 100644
> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
> 2. The second transaction contains a physical update to the free space btrees
> of AG 3 to release the former BMBT block and a second physical update to the
> free space btrees of AG 7 to release the unmapped file space.
> - Observe that the the physical updates are resequenced in the correct order
> + Observe that the physical updates are resequenced in the correct order
> when possible.
> Attached to the transaction is a an extent free done (EFD) log item.
> The EFD contains a pointer to the EFI logged in transaction #1 so that log
I feel guilty here. Only considering the diff,
Reviewed-by: Bagas Sanjaya <[email protected]>
Not sure if jon pick this or v2, though.
Sorry for inconvenience.
--
An old man doll... just what I always wanted! - Clara
On Tue, Sep 19, 2023 at 10:15:21PM +0100, Matthew Wilcox wrote:
> On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote:
> > [cc [email protected]]
> >
> > Hi Charles,
> >
> > For future reference, can you CC the XFS list on XFS documentation
> > changes please? That's much preferable to sending patches to random
> > developers and hoping they notice it....
> >
> > On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote:
> > > Remove the repeated word "the" in comments.
> > >
> > > Signed-off-by: Charles Han <[email protected]>
> > > ---
> > > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
>
> To be fair, this new file isn't listed in MAINTAINERS, so
> scripts/get_maintainer.pl doesn't know about it. May I
> suggest the attached patch?
> From e0eb2f0d1425e6a5dae23c983eb793afa5d040c1 Mon Sep 17 00:00:00 2001
> From: "Matthew Wilcox (Oracle)" <[email protected]>
> Date: Tue, 19 Sep 2023 17:12:45 -0400
> Subject: [PATCH] XFS: Update MAINTAINERS to catch all XFS documentation
>
> Assumes that all XFS documentation will be prefixed with xfs-, which
> seems like a good policy anyway.
>
> Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
> ---
> MAINTAINERS | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bf0f54c24f81..3554195022ee 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23640,8 +23640,7 @@ T: git git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
> P: Documentation/filesystems/xfs-maintainer-entry-profile.rst
> F: Documentation/ABI/testing/sysfs-fs-xfs
> F: Documentation/admin-guide/xfs.rst
> -F: Documentation/filesystems/xfs-delayed-logging-design.rst
> -F: Documentation/filesystems/xfs-self-describing-metadata.rst
> +F: Documentation/filesystems/xfs-*
> F: fs/xfs/
> F: include/uapi/linux/dqblk_xfs.h
> F: include/uapi/linux/fsmap.h
Looks fine to me.
Reviewed-by: Dave Chinner <[email protected]>
--
Dave Chinner
[email protected]
On Tue, Sep 19, 2023 at 10:15:21 PM +0100, Matthew Wilcox wrote:
> On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote:
>> [cc [email protected]]
>>
>> Hi Charles,
>>
>> For future reference, can you CC the XFS list on XFS documentation
>> changes please? That's much preferable to sending patches to random
>> developers and hoping they notice it....
>>
>> On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote:
>> > Remove the repeated word "the" in comments.
>> >
>> > Signed-off-by: Charles Han <[email protected]>
>> > ---
>> > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
>
> To be fair, this new file isn't listed in MAINTAINERS, so
> scripts/get_maintainer.pl doesn't know about it. May I
> suggest the attached patch?
>
> [2. text/plain; 0001-XFS-Update-MAINTAINERS-to-catch-all-XFS-documentatio.patch]...
Hi Jonathan,
I am planning to apply these two patches to xfs-linux's for-next branch and
later send them to Linus. Please let me know if you have any objections.
--
Chandan