2023-09-18 03:30:58

by John Watts

[permalink] [raw]
Subject: Re: [PATCH v3 3/3] ASoC: dt-bindings: wlf,wm8782: Add wlf,fsampen property

On Mon, Sep 18, 2023 at 03:37:26AM +1000, John Watts wrote:
> +Optional properties:
> +
> + - wlf,fsampen : FSAMPEN pin value, 0 for low, 1 for high, 2 for disconnected
> +

Uh-oh, I forgot to specify what it defaults to.
Should I reply to this patch with a fix or re-send the entire series after I get feedback?

John.


2023-09-18 18:07:14

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH v3 3/3] ASoC: dt-bindings: wlf,wm8782: Add wlf,fsampen property

On Mon, Sep 18, 2023 at 03:46:06AM +1000, John Watts wrote:
> On Mon, Sep 18, 2023 at 03:37:26AM +1000, John Watts wrote:
> > +Optional properties:
> > +
> > + - wlf,fsampen : FSAMPEN pin value, 0 for low, 1 for high, 2 for disconnected
> > +
>
> Uh-oh, I forgot to specify what it defaults to.
> Should I reply to this patch with a fix or re-send the entire series after I get feedback?
>

I would probably send a new spin with the fix and my acks.

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles