2023-09-18 09:23:51

by Usama Arif

Subject: [PATCH] memblock: add missing argument definition

Description of argument memblock_type was missing in the commit
that introduced it.

Fixes: 70083e1c8ab4 ("memblock: pass memblock_type to memblock_setclr_flag")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Usama Arif <[email protected]>
---
mm/memblock.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/mm/memblock.c b/mm/memblock.c
index 8f7a0cb668d4..fd492e5bbdbc 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -892,6 +892,7 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size)

/**
* memblock_setclr_flag - set or clear flag for a memory region
+ * @type: memblock type to set/clear flag for
* @base: base address of the region
* @size: size of the region
* @set: set or clear the flag
--
2.25.1

2023-09-18 16:52:01

by Mike Rapoport

Subject: Re: [PATCH] memblock: add missing argument definition

On Mon, Sep 18, 2023 at 10:06:57AM +0100, Usama Arif wrote:
> Description of argument memblock_type was missing in the commit
> that introduced it.
>
> Fixes: 70083e1c8ab4 ("memblock: pass memblock_type to memblock_setclr_flag")
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Usama Arif <[email protected]>

Reviewed-by: Mike Rapoport (IBM) <[email protected]>

Andrew, the commit being fixed is in mm-unstable, can you please pick it
up?

> ---
> mm/memblock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 8f7a0cb668d4..fd492e5bbdbc 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -892,6 +892,7 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size)
>
> /**
> * memblock_setclr_flag - set or clear flag for a memory region
> + * @type: memblock type to set/clear flag for
> * @base: base address of the region
> * @size: size of the region
> * @set: set or clear the flag
> --
> 2.25.1
>

--
Sincerely yours,
Mike.