Hi,
make W=1 dtbs is reporting couple of issues which this series is going to
address. There is also one more changes related to removing additional
compatible string which is reported by dtbs_check.
Thanks,
Michal
Michal Simek (6):
arm64: xilinx: Do not use '_' in DT node names
arm64: xilinx: Use lower case for partition address
arm64: xilinx: Remove mt25qu512a compatible string from SOM
arm64: xilinx: Put ethernet phys to mdio node
arm64: xilinx: Remove address/size-cells from flash node
arm64: xilinx: Remove address/size-cells from gem nodes
.../boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 8 +++---
.../dts/xilinx/zynqmp-zc1751-xm015-dc1.dts | 8 ++++--
.../dts/xilinx/zynqmp-zc1751-xm016-dc2.dts | 16 +++++++-----
.../dts/xilinx/zynqmp-zc1751-xm017-dc3.dts | 8 ++++--
.../dts/xilinx/zynqmp-zc1751-xm018-dc4.dts | 26 +++++++++++--------
.../dts/xilinx/zynqmp-zc1751-xm019-dc5.dts | 8 ++++--
.../boot/dts/xilinx/zynqmp-zcu100-revC.dts | 4 +--
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 14 +++-------
8 files changed, 51 insertions(+), 41 deletions(-)
--
2.36.1
mt25qu512a is not documented in DT binding that's why remove it.
Signed-off-by: Michal Simek <[email protected]>
---
arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
index 157dcb4a27a8..cd5cd7f3b5ce 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
@@ -131,7 +131,7 @@ mux {
&qspi { /* MIO 0-5 - U143 */
status = "okay";
spi_flash: flash@0 { /* MT25QU512A */
- compatible = "mt25qu512a", "jedec,spi-nor"; /* 64MB */
+ compatible = "jedec,spi-nor"; /* 64MB */
#address-cells = <1>;
#size-cells = <1>;
reg = <0>;
--
2.36.1
Hi Michal,
Thank you for the patch.
On Mon, Sep 18, 2023 at 02:41:14PM +0200, Michal Simek wrote:
> mt25qu512a is not documented in DT binding that's why remove it.
How about adding the compatible string to the bindings instead ?
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> index 157dcb4a27a8..cd5cd7f3b5ce 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> @@ -131,7 +131,7 @@ mux {
> &qspi { /* MIO 0-5 - U143 */
> status = "okay";
> spi_flash: flash@0 { /* MT25QU512A */
> - compatible = "mt25qu512a", "jedec,spi-nor"; /* 64MB */
> + compatible = "jedec,spi-nor"; /* 64MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0>;
--
Regards,
Laurent Pinchart
Lower case should be used for register address.
Issue is reported as:
flash@0: partitions: Unevaluated properties are not allowed
('partition@22A0000' was unexpected)
Signed-off-by: Michal Simek <[email protected]>
---
arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
index c4774a42d5fc..157dcb4a27a8 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
@@ -222,9 +222,9 @@ partition@2280000 {
label = "Secure OS Storage";
reg = <0x2280000 0x20000>; /* 128KB */
};
- partition@22A0000 {
+ partition@22a0000 {
label = "User";
- reg = <0x22A0000 0x1d60000>; /* 29.375 MB */
+ reg = <0x22a0000 0x1d60000>; /* 29.375 MB */
};
};
};
--
2.36.1
Hi Michal,
Thank you for the patch.
On Mon, Sep 18, 2023 at 02:41:13PM +0200, Michal Simek wrote:
> Lower case should be used for register address.
> Issue is reported as:
> flash@0: partitions: Unevaluated properties are not allowed
> ('partition@22A0000' was unexpected)
>
> Signed-off-by: Michal Simek <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> index c4774a42d5fc..157dcb4a27a8 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> @@ -222,9 +222,9 @@ partition@2280000 {
> label = "Secure OS Storage";
> reg = <0x2280000 0x20000>; /* 128KB */
> };
> - partition@22A0000 {
> + partition@22a0000 {
> label = "User";
> - reg = <0x22A0000 0x1d60000>; /* 29.375 MB */
> + reg = <0x22a0000 0x1d60000>; /* 29.375 MB */
> };
> };
> };
--
Regards,
Laurent Pinchart
Partitions are described via fixed-partitions that's why there is no need
to have address/size-cells in flash node.
Signed-off-by: Michal Simek <[email protected]>
---
arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
index cd5cd7f3b5ce..51622896b1b1 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
@@ -132,8 +132,6 @@ &qspi { /* MIO 0-5 - U143 */
status = "okay";
spi_flash: flash@0 { /* MT25QU512A */
compatible = "jedec,spi-nor"; /* 64MB */
- #address-cells = <1>;
- #size-cells = <1>;
reg = <0>;
spi-tx-bus-width = <4>;
spi-rx-bus-width = <4>;
--
2.36.1
Hi Laurent,
On 9/18/23 17:01, Laurent Pinchart wrote:
> Hi Michal,
>
> Thank you for the patch.
>
> On Mon, Sep 18, 2023 at 02:41:14PM +0200, Michal Simek wrote:
>> mt25qu512a is not documented in DT binding that's why remove it.
>
> How about adding the compatible string to the bindings instead ?
>
>> Signed-off-by: Michal Simek <[email protected]>
>> ---
>>
>> arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
>> index 157dcb4a27a8..cd5cd7f3b5ce 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
>> @@ -131,7 +131,7 @@ mux {
>> &qspi { /* MIO 0-5 - U143 */
>> status = "okay";
>> spi_flash: flash@0 { /* MT25QU512A */
>> - compatible = "mt25qu512a", "jedec,spi-nor"; /* 64MB */
>> + compatible = "jedec,spi-nor"; /* 64MB */
>> #address-cells = <1>;
>> #size-cells = <1>;
>> reg = <0>;
>
arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts is using only jedec,spi-nor
Renesas and our SOM are using it.
arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi:310: compatible =
"micron,mt25qu512a", "jedec,spi-nor";
arch/arm64/boot/dts/renesas/rzg2lc-smarc-som.dtsi:239: compatible =
"micron,mt25qu512a", "jedec,spi-nor";
arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts:136: compatible =
"micron,mt25qu512a", "jedec,spi-nor"; /* 64MB */
Rob/Krzysztof/Conor: What's the recommendation? I see 02g variant listed and
micron-st also has 256a/512a variants.
Thanks,
Michal
On 9/18/23 14:41, Michal Simek wrote:
> Hi,
>
> make W=1 dtbs is reporting couple of issues which this series is going to
> address. There is also one more changes related to removing additional
> compatible string which is reported by dtbs_check.
>
> Thanks,
> Michal
>
>
> Michal Simek (6):
> arm64: xilinx: Do not use '_' in DT node names
> arm64: xilinx: Use lower case for partition address
> arm64: xilinx: Remove mt25qu512a compatible string from SOM
> arm64: xilinx: Put ethernet phys to mdio node
> arm64: xilinx: Remove address/size-cells from flash node
> arm64: xilinx: Remove address/size-cells from gem nodes
>
> .../boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 8 +++---
> .../dts/xilinx/zynqmp-zc1751-xm015-dc1.dts | 8 ++++--
> .../dts/xilinx/zynqmp-zc1751-xm016-dc2.dts | 16 +++++++-----
> .../dts/xilinx/zynqmp-zc1751-xm017-dc3.dts | 8 ++++--
> .../dts/xilinx/zynqmp-zc1751-xm018-dc4.dts | 26 +++++++++++--------
> .../dts/xilinx/zynqmp-zc1751-xm019-dc5.dts | 8 ++++--
> .../boot/dts/xilinx/zynqmp-zcu100-revC.dts | 4 +--
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 14 +++-------
> 8 files changed, 51 insertions(+), 41 deletions(-)
>
Applied.
M