2023-09-19 01:03:22

by Yang Li

[permalink] [raw]
Subject: [PATCH net-next] netdev: Remove unneeded semicolon

./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
Signed-off-by: Yang Li <[email protected]>
---
drivers/dpll/dpll_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c
index 764437a0661b..e20daba6896a 100644
--- a/drivers/dpll/dpll_netlink.c
+++ b/drivers/dpll/dpll_netlink.c
@@ -844,7 +844,7 @@ dpll_pin_find(u64 clock_id, struct nlattr *mod_name_attr,
return ERR_PTR(-EINVAL);
}
pin_match = pin;
- };
+ }
}
if (!pin_match) {
NL_SET_ERR_MSG(extack, "not found");
--
2.20.1.7.g153144c


2023-09-20 16:30:06

by Vadim Fedorenko

[permalink] [raw]
Subject: Re: [PATCH net-next] netdev: Remove unneeded semicolon

On 19/09/2023 02:03, Yang Li wrote:
> ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
> Signed-off-by: Yang Li <[email protected]>

Hi Yang!
There was a report from Intel's bot too about the issue, could you
please add the tags from it?

Reported-by: kernel test robot <[email protected]>
Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]/

Thanks!

> ---
> drivers/dpll/dpll_netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c
> index 764437a0661b..e20daba6896a 100644
> --- a/drivers/dpll/dpll_netlink.c
> +++ b/drivers/dpll/dpll_netlink.c
> @@ -844,7 +844,7 @@ dpll_pin_find(u64 clock_id, struct nlattr *mod_name_attr,
> return ERR_PTR(-EINVAL);
> }
> pin_match = pin;
> - };
> + }
> }
> if (!pin_match) {
> NL_SET_ERR_MSG(extack, "not found");

2023-09-21 21:25:50

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next] netdev: Remove unneeded semicolon

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <[email protected]>:

On Tue, 19 Sep 2023 09:03:05 +0800 you wrote:
> ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/dpll/dpll_netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [net-next] netdev: Remove unneeded semicolon
https://git.kernel.org/netdev/net-next/c/f20161cf5165

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


2023-09-22 01:58:24

by Vadim Fedorenko

[permalink] [raw]
Subject: Re: [PATCH net-next] netdev: Remove unneeded semicolon

On 21/09/2023 14:07, Paolo Abeni wrote:
> On Wed, 2023-09-20 at 12:10 +0100, Vadim Fedorenko wrote:
>> On 19/09/2023 02:03, Yang Li wrote:
>>> ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
>>>
>>> Reported-by: Abaci Robot <[email protected]>
>>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
>>> Signed-off-by: Yang Li <[email protected]>
>>
>> Hi Yang!
>> There was a report from Intel's bot too about the issue, could you
>> please add the tags from it?
>>
>> Reported-by: kernel test robot <[email protected]>
>> Closes:
>> https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> No need to repost, the pw tools import the above tags automatically.

Ok, cool.

The fix itself is trivial.

Reviewed-by: Vadim Fedorenko <[email protected]>

2023-09-22 16:54:10

by Paolo Abeni

[permalink] [raw]
Subject: Re: [PATCH net-next] netdev: Remove unneeded semicolon

On Wed, 2023-09-20 at 12:10 +0100, Vadim Fedorenko wrote:
> On 19/09/2023 02:03, Yang Li wrote:
> > ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
> > Signed-off-by: Yang Li <[email protected]>
>
> Hi Yang!
> There was a report from Intel's bot too about the issue, could you
> please add the tags from it?
>
> Reported-by: kernel test robot <[email protected]>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/[email protected]/

No need to repost, the pw tools import the above tags automatically.

Cheers,

Paolo