err is assigned first, so it does not need to initialize the assignment.
Signed-off-by: Li zeming <[email protected]>
---
kernel/profile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/profile.c b/kernel/profile.c
index 8a77769bc4b4..87acc7a9d7e2 100644
--- a/kernel/profile.c
+++ b/kernel/profile.c
@@ -465,7 +465,7 @@ int __ref create_proc_profile(void)
enum cpuhp_state online_state;
#endif
- int err = 0;
+ int err;
if (!prof_on)
return 0;
--
2.18.2
Hi Li,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Li-zeming/profile-Remove-unnecessary-0-values-from-err/20230919-094202
base: linus/master
patch link: https://lore.kernel.org/r/20230919014126.8168-1-zeming%40nfschina.com
patch subject: [PATCH] profile: Remove unnecessary ‘0’ values from err
config: i386-randconfig-141-20230921 (https://download.01.org/0day-ci/archive/20231012/[email protected]/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce: (https://download.01.org/0day-ci/archive/20231012/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Reported-by: Dan Carpenter <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:
kernel/profile.c:491 create_proc_profile() error: uninitialized symbol 'err'.
vim +/err +491 kernel/profile.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 467
1997ab2b2a8d46 Li zeming 2023-09-19 468 int err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 469
^1da177e4c3f41 Linus Torvalds 2005-04-16 470 if (!prof_on)
^1da177e4c3f41 Linus Torvalds 2005-04-16 471 return 0;
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 472 #ifdef CONFIG_SMP
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 473 err = cpuhp_setup_state(CPUHP_PROFILE_PREPARE, "PROFILE_PREPARE",
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 474 profile_prepare_cpu, profile_dead_cpu);
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 475 if (err)
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 476 return err;
c270a817196a93 Srivatsa S. Bhat 2014-03-11 477
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 478 err = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "AP_PROFILE_ONLINE",
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 479 profile_online_cpu, NULL);
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 480 if (err < 0)
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 481 goto err_state_prep;
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 482 online_state = err;
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 483 err = 0;
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 484 #endif
err is uninitialized on single processor systems.
c33fff0afbef4f Denis V. Lunev 2008-04-29 485 entry = proc_create("profile", S_IWUSR | S_IRUGO,
97a32539b9568b Alexey Dobriyan 2020-02-03 486 NULL, &profile_proc_ops);
1ad82fd547c716 Paolo Ciarrocchi 2008-01-25 487 if (!entry)
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 488 goto err_state_onl;
271a15eabe0945 David Howells 2013-04-12 489 proc_set_size(entry, (1 + prof_len) * sizeof(atomic_t));
c270a817196a93 Srivatsa S. Bhat 2014-03-11 490
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 @491 return err;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki