2023-09-19 04:49:48

by Wu Yunchuan

[permalink] [raw]
Subject: [PATCH v2 wireless-next 1/9] wifi: ar5523: Remove unnecessary (void*) conversions

No need cast (void*) to (struct ar5523_cmd_hdr *).

Signed-off-by: Wu Yunchuan <[email protected]>
---
drivers/net/wireless/ath/ar5523/ar5523.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireless/ath/ar5523/ar5523.c
index 19f61225a708..43e0db78d42b 100644
--- a/drivers/net/wireless/ath/ar5523/ar5523.c
+++ b/drivers/net/wireless/ath/ar5523/ar5523.c
@@ -256,7 +256,7 @@ static int ar5523_cmd(struct ar5523 *ar, u32 code, const void *idata,
/* always bulk-out a multiple of 4 bytes */
xferlen = (sizeof(struct ar5523_cmd_hdr) + ilen + 3) & ~3;

- hdr = (struct ar5523_cmd_hdr *)cmd->buf_tx;
+ hdr = cmd->buf_tx;
memset(hdr, 0, sizeof(struct ar5523_cmd_hdr));
hdr->len = cpu_to_be32(xferlen);
hdr->code = cpu_to_be32(code);
--
2.30.2


2023-09-20 21:15:57

by Jeff Johnson

[permalink] [raw]
Subject: Re: [PATCH v2 wireless-next 1/9] wifi: ar5523: Remove unnecessary (void*) conversions

On 9/18/2023 9:49 PM, Wu Yunchuan wrote:
> No need cast (void*) to (struct ar5523_cmd_hdr *).
>
> Signed-off-by: Wu Yunchuan <[email protected]>
Reviewed-by: Jeff Johnson <[email protected]>


2023-09-21 18:26:39

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2 wireless-next 1/9] wifi: ar5523: Remove unnecessary (void*) conversions

Wu Yunchuan <[email protected]> wrote:

> No need cast (void*) to (struct ar5523_cmd_hdr *).
>
> Signed-off-by: Wu Yunchuan <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

6 patches applied to ath-next branch of ath.git, thanks.

37c113e94fa0 wifi: ar5523: Remove unnecessary (void*) conversions
9705103f8e8e wifi: wcn36xx: remove unnecessary (void*) conversions
4bd0f7d0f311 wifi: ath5k: remove unnecessary (void*) conversions
779163fa1a37 wifi: ath6kl: remove unnecessary (void*) conversions
16e972d5767a wifi: ath10k: Remove unnecessary (void*) conversions
e5e8b38f0c05 wifi: ath12k: Remove unnecessary (void*) conversions

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches